#29521 closed enhancement (fixed)

Modify giac upstream tarball to remove non-portable filenames

Reported by: mkoeppe Owned by:
Priority: blocker Milestone: sage-9.1
Component: packages: standard Keywords:
Cc: arojas, dimpase, frederichan, parisse, slelievre, infinity0, saraedum, thansen, gh-timokau, fbissey Merged in:
Authors: Matthias Koeppe Reviewers: François Bissey, Dima Pasechnik
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: a9b4666 (Commits, GitHub, GitLab) Commit: a9b4666bbc1bf03fa2d74745486dc5cfed811898
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

http://www-fourier.ujf-grenoble.fr/~parisse/debian/dists/stable/main/source/

When preparing the reduced tarball with spkg-src, we should rename the non-portable file names with a colon in them:

$ find . -name "*:*"
./doc/pari/Programming_in_GP:_control_statements.html
./doc/pari/Programming_in_GP:_other_specific_functions.html
./doc/pari/cont_Programming_in_GP:_other_specific_functions.html
./doc/pari/cont_Programming_in_GP:_control_statements.html

(problematic at least on Windows - as reported in #28549.)

Previous updates:

Follow-up: #29552 (Upgrade giac to 1.5.0-87) ... for Sage 9.2

Attachments (1)

giac-1.5.0.63-p0.tar.bz2 (34.9 MB) - added by mkoeppe 16 months ago.

Change History (32)

comment:1 Changed 16 months ago by mkoeppe

  • Description modified (diff)

comment:2 Changed 16 months ago by mkoeppe

  • Description modified (diff)

comment:3 Changed 16 months ago by mkoeppe

  • Cc fbissey added
  • Summary changed from Upgrade giac to 1.5.0-87 to Upgrade giac to 1.5.0-87 and fix non-portable filenames

comment:4 Changed 16 months ago by dimpase

  • Report Upstream changed from N/A to Not yet reported upstream; Will do shortly.

comment:5 Changed 16 months ago by fbissey

Would be nice to do this. There are a few trivial doctests impacted by this. But I'll wait to know what upstream intend to do about the naming before going ahead.

comment:6 Changed 16 months ago by dimpase

  • Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.

comment:7 follow-ups: Changed 16 months ago by parisse

This is a problem that should be reported to PARI: https://pari.math.u-bordeaux.fr/dochtml/html-stable.tgz

comment:8 in reply to: ↑ 7 Changed 16 months ago by fbissey

Replying to parisse:

This is a problem that should be reported to PARI: https://pari.math.u-bordeaux.fr/dochtml/html-stable.tgz

Thanks for that . Which now begs the question, should we install pari's html doc with giac? We already have the documentation which comes with pari, in pdf if I am not mistaken.

comment:9 Changed 16 months ago by parisse

The HTML doc is intended to be used from Xcas (Help, Manuals, PARI-GP), I don't think you will need it to run giac inside sage.

comment:10 Changed 16 months ago by fbissey

xcas is the fltk application, right? I am not sure we ever build it in sage as we would have to make sure there is a proper fltk install and that it is detected properly. So, not shipping those won't hurt I guess.

comment:11 Changed 16 months ago by frederichan

Yes xcas is never built by the spkg because we put in spkg-install: sdh_configure --disable-gui I did this long ago to prevent the configure script to find a bad version of fltk that might be installed on the system.

comment:12 Changed 16 months ago by mkoeppe

OK sounds like our just spkg-src needs to delete more stuff.

comment:13 in reply to: ↑ 7 Changed 16 months ago by dimpase

Replying to parisse:

This is a problem that should be reported to PARI: https://pari.math.u-bordeaux.fr/dochtml/html-stable.tgz

apparently it's already fixed, for the upcoming release, i.e. https://pari.math.u-bordeaux.fr/dochtml/html.tgz I see no : in filenames.

For html-stable, I see

-rw-r--r-- 1 dimpase dimpase   26979 Jul 19  2016  Programming_in_GP:_control_statements.html
-rw-r--r-- 1 dimpase dimpase   39993 Dec  1  2018  Programming_in_GP__control_statements.html
-rw-r--r-- 1 dimpase dimpase   46872 Jul 19  2016  Programming_in_GP:_other_specific_functions.html
-rw-r--r-- 1 dimpase dimpase   78935 Dec  1  2018  Programming_in_GP__other_specific_functions.html

so these files with : are just leftovers, by looking at dates...

comment:14 Changed 16 months ago by mkoeppe

A decision needs to be made whether for 9.1, we want to do the update to to 1.5.0-87 or just clean up the tarball of 1.5.0-63

comment:15 Changed 16 months ago by mkoeppe

  • Priority changed from major to blocker

comment:16 follow-up: Changed 16 months ago by mkoeppe

Would someone who knows about the spkg-src be willing to update it?

comment:17 in reply to: ↑ 16 Changed 16 months ago by fbissey

Replying to mkoeppe:

Would someone who knows about the spkg-src be willing to update it?

I'll admit that I don't really want to touch it. I would probably have wanted to do the whole thing slightly differently.

comment:18 Changed 16 months ago by mkoeppe

  • Branch set to u/mkoeppe/upgrade_giac_to_1_5_0_87_and_fix_non_portable_filenames

comment:19 Changed 16 months ago by mkoeppe

  • Commit set to 31d2b939125b5c7c1c0fec63c11490a5eb19f4cb
  • Description modified (diff)
  • Summary changed from Upgrade giac to 1.5.0-87 and fix non-portable filenames to Modify giac upstream tarball to remove non-portable filenames

New commits:

036dbbabuild/pkgs/giac/spkg-src: Remove files with nonportable names and other unneeded files
31d2b93build/pkgs/giac/spkg-src: Make the script work on macOS too

comment:20 Changed 16 months ago by git

  • Commit changed from 31d2b939125b5c7c1c0fec63c11490a5eb19f4cb to 84df0e5db4065e81358473bbe6eca59bd134faf4

Branch pushed to git repo; I updated commit sha1. New commits:

84df0e5build/pkgs/giac: New upstream tarball

comment:21 Changed 16 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, in a later stable release.
  • Status changed from new to needs_review

comment:22 Changed 16 months ago by fbissey

  • Reviewers set to François Bissey

LGTM. I didn't even know you could use that syntax for tar under linux, looks much better now. Have to check a couple of things before switching it to positive.

comment:23 Changed 16 months ago by dimpase

  • Reviewers François Bissey deleted

does this work? I would worry about - in the patch level.

comment:24 Changed 16 months ago by dimpase

  • Reviewers set to François Bissey, Dima Pasechnik

Changed 16 months ago by mkoeppe

comment:25 Changed 16 months ago by git

  • Commit changed from 84df0e5db4065e81358473bbe6eca59bd134faf4 to a9b4666bbc1bf03fa2d74745486dc5cfed811898

Branch pushed to git repo; I updated commit sha1. New commits:

081b1d2Fixup
a9b4666fixup

comment:26 Changed 16 months ago by mkoeppe

This one works for me.

comment:27 Changed 16 months ago by mkoeppe

Using -p0 because that becomes part of the tarball name.

comment:28 Changed 16 months ago by dimpase

  • Status changed from needs_review to positive_review

afk now, but OK.

comment:29 Changed 16 months ago by fbissey

I checked the bit I was worried about (whether some stuff in doc/Makefile.am could lead to a breakage) and I am definitely OK with this.

comment:30 Changed 16 months ago by mkoeppe

Thanks!

comment:31 Changed 16 months ago by vbraun

  • Branch changed from u/mkoeppe/upgrade_giac_to_1_5_0_87_and_fix_non_portable_filenames to a9b4666bbc1bf03fa2d74745486dc5cfed811898
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.