Opened 22 months ago
Last modified 6 weeks ago
#29507 new enhancement
Provide precious variables (CFLAGS, PKG_CONFIG_PATH, ...) to make
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.6 |
Component: | build: configure | Keywords: | sd111 |
Cc: | jhpalmieri, gh-mwageringel, dimpase, fbissey, gh-kliem, dcoudert | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
autotools have a concept of "precious variables" (https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Setting-Output-Variables.html).
Because we do not use automake, many standard precious variables such as CFLAGS
, PKG_CONFIG_PATH
are not actually applied to building.
This should be fixed to make our build system more standard.
(from discussions in #29504, and a discussion with gh-mwageringel on a ticket I lost track of)
Likewise, for variables set by .homebrew-build-env
(https://groups.google.com/d/msg/sage-devel/taOGXzXq6Lk/ePcXsCvhBAAJ)
See also:
- #23570 Make SAGE* environment variables set at configure time to stick
Change History (12)
comment:1 Changed 22 months ago by
comment:2 Changed 22 months ago by
- Cc fbissey added
- Description modified (diff)
comment:3 Changed 19 months ago by
- Cc gh-kliem added
comment:4 Changed 19 months ago by
- Cc dcoudert added
comment:5 Changed 19 months ago by
- Description modified (diff)
comment:6 Changed 19 months ago by
using automake will also make installing of gettext-related stuff in bootstrap easy
comment:7 Changed 17 months ago by
- Milestone changed from sage-9.2 to sage-9.3
comment:8 Changed 14 months ago by
- Keywords sd111 added
comment:9 Changed 13 months ago by
CFLAGS
and similar were taken care of in #30375.
comment:10 Changed 12 months ago by
- Milestone changed from sage-9.3 to sage-9.4
Setting new milestone based on a cursory review of ticket status, priority, and last modification date.
comment:11 Changed 6 months ago by
- Milestone changed from sage-9.4 to sage-9.5
comment:12 Changed 6 weeks ago by
- Milestone changed from sage-9.5 to sage-9.6
Easiest way to fix it is probably to use automake. Our targets in build/make/Makefile would just become "local" targets (https://www.gnu.org/software/automake/manual/html_node/Extending.html#Extending)