Opened 3 years ago
Last modified 3 months ago
#29507 new enhancement
Provide precious variables (CFLAGS, PKG_CONFIG_PATH, ...) to make
Reported by: | Matthias Köppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.8 |
Component: | build: configure | Keywords: | sd111 |
Cc: | John Palmieri, Markus Wageringel, Dima Pasechnik, François Bissey, gh-kliem, David Coudert | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
autotools have a concept of "precious variables" (https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Setting-Output-Variables.html).
Because we do not use automake, many standard precious variables such as CFLAGS
, PKG_CONFIG_PATH
are not actually applied to building.
This should be fixed to make our build system more standard.
(from discussions in #29504, and a discussion with gh-mwageringel on a ticket I lost track of)
Likewise, for variables set by .homebrew-build-env
(https://groups.google.com/d/msg/sage-devel/taOGXzXq6Lk/ePcXsCvhBAAJ)
See also:
- #23570 Make SAGE* environment variables set at configure time to stick
Change History (14)
comment:1 Changed 3 years ago by
comment:2 Changed 3 years ago by
Cc: | François Bissey added |
---|---|
Description: | modified (diff) |
comment:3 Changed 2 years ago by
Cc: | gh-kliem added |
---|
comment:4 Changed 2 years ago by
Cc: | David Coudert added |
---|
comment:5 Changed 2 years ago by
Description: | modified (diff) |
---|
comment:6 Changed 2 years ago by
using automake will also make installing of gettext-related stuff in bootstrap easy
comment:7 Changed 2 years ago by
Milestone: | sage-9.2 → sage-9.3 |
---|
comment:8 Changed 2 years ago by
Keywords: | sd111 added |
---|
comment:10 Changed 22 months ago by
Milestone: | sage-9.3 → sage-9.4 |
---|
Setting new milestone based on a cursory review of ticket status, priority, and last modification date.
comment:11 Changed 17 months ago by
Milestone: | sage-9.4 → sage-9.5 |
---|
comment:12 Changed 12 months ago by
Milestone: | sage-9.5 → sage-9.6 |
---|
comment:13 Changed 8 months ago by
Milestone: | sage-9.6 → sage-9.7 |
---|
comment:14 Changed 3 months ago by
Milestone: | sage-9.7 → sage-9.8 |
---|
Easiest way to fix it is probably to use automake. Our targets in build/make/Makefile would just become "local" targets (https://www.gnu.org/software/automake/manual/html_node/Extending.html#Extending)