#29505 closed enhancement (fixed)

add missing raise and fix some imports in number fields

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.1
Component: number fields Keywords:
Cc: tscrim, vdelecroix Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: fcec17a (Commits, GitHub, GitLab) Commit: fcec17aca3d1a5ac9035e696fcf34accd99d4c70
Dependencies: Stopgaps:

Status badges

Description

as suggested by lgtm

Change History (9)

comment:1 Changed 22 months ago by chapoton

  • Branch set to u/chapoton/29505
  • Status changed from new to needs_review

comment:2 Changed 22 months ago by git

  • Commit set to 574e3a32555a9e215cd5bacd5177ed811b34015c

Branch pushed to git repo; I updated commit sha1. New commits:

574e3a3add a missing raise and fix some imports (suggested by lgtm) in number fields

comment:3 Changed 22 months ago by git

  • Commit changed from 574e3a32555a9e215cd5bacd5177ed811b34015c to fcec17aca3d1a5ac9035e696fcf34accd99d4c70

Branch pushed to git repo; I updated commit sha1. New commits:

fcec17asome further details in relative number fields

comment:4 Changed 22 months ago by chapoton

  • Cc tscrim vdelecroix added

green bot, please review

comment:5 Changed 22 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:6 follow-up: Changed 22 months ago by chapoton

Thanks a lot, Travis. How are things going ?

comment:7 in reply to: ↑ 6 Changed 22 months ago by tscrim

Replying to chapoton:

Thanks a lot, Travis.

No problem.

How are things going ?

Going okay. Right now I am just waiting on the Australian boarders to reopen. UQ has been using online classes for the past month. How are things for you?

comment:8 Changed 22 months ago by chapoton

Well, going roughly ok. Still one more month at home coming, at least.

comment:9 Changed 22 months ago by vbraun

  • Branch changed from u/chapoton/29505 to fcec17aca3d1a5ac9035e696fcf34accd99d4c70
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.