Opened 3 years ago

Closed 3 years ago

#29501 closed defect (fixed)

spkg-check.in: Do not use sdh_make to do 'make check', to avoid misleading messages

Reported by: mkoeppe Owned by:
Priority: minor Milestone: sage-9.1
Component: build Keywords:
Cc: dimpase, jhpalmieri, embray Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik, John Palmieri
Report Upstream: N/A Work issues:
Branch: c53ddc7 (Commits, GitHub, GitLab) Commit: c53ddc71444cebbe3ae99f43d825471d3c58e766
Dependencies: #29510 Stopgaps:

Status badges

Description (last modified by mkoeppe)

sdh_make, even when used for make check, prints the misleading message "Error building $PKG_NAME"

$ grep sdh_make build/pkgs/*/spkg-check.in
build/pkgs/awali/spkg-check.in:sdh_make check
build/pkgs/barvinok/spkg-check.in:sdh_make check
build/pkgs/cocoalib/spkg-check.in:sdh_make check
build/pkgs/e_antic/spkg-check.in:sdh_make check
build/pkgs/fflas_ffpack/spkg-check.in:sdh_make check
build/pkgs/isl/spkg-check.in:sdh_make check
build/pkgs/openblas/spkg-check.in:sdh_make tests $OPENBLAS_CONFIGURE
build/pkgs/openblas/spkg-check.in:        sdh_make tests $OPENBLAS_CONFIGURE
build/pkgs/polylib/spkg-check.in:sdh_make check
build/pkgs/polymake/spkg-check.in:sdh_make test
build/pkgs/symengine/spkg-check.in:sdh_make test
build/pkgs/tides/spkg-check.in:sdh_make check AM_CFLAGS="" AM_FFLAGS=""

In the present ticket, we fix this.

We note that when sdh_make is used for building in spkg-install.in, there is duplication with a message printed by sage-spkg afterwards. For example in https://github.com/mkoeppe/sage/runs/581877049:

  [python3-3.7.3.p1]   TypeError: can only concatenate str (not "NoneType") to str
  [python3-3.7.3.p1]   make[2]: *** [Makefile:626: sharedmods] Error 1
  [python3-3.7.3.p1]   make[2]: Target 'all' not remade because of errors.
  [python3-3.7.3.p1]   make[2]: Leaving directory '/home/runner/work/sage/sage/.tox/local-conda-forge-ubuntu-minimal/local/var/tmp/sage/build/python3-3.7.3.p1/src'
  [python3-3.7.3.p1]   ********************************************************************************
  [python3-3.7.3.p1]   Error building python3-3.7.3.p1
  [python3-3.7.3.p1]   ********************************************************************************
  [python3-3.7.3.p1]   
  [python3-3.7.3.p1]   real	3m37.614s
  [python3-3.7.3.p1]   user	1m37.298s
  [python3-3.7.3.p1]   sys	0m11.320s
  [python3-3.7.3.p1]   ************************************************************************
  [python3-3.7.3.p1]   Error building package python3-3.7.3.p1
  [python3-3.7.3.p1]   ************************************************************************
  [python3-3.7.3.p1] Full log file: /home/runner/work/sage/sage/logs/pkgs/python3-3.7.3.p1.log

However, as this does not have the potential to mislead, we will take care of this on another ticket.

Change History (15)

comment:1 Changed 3 years ago by jhpalmieri

Maybe just create a new function called sdh_make_check which is exactly the same as sdh_make but has a different error message. Or allow sdh_make to have an optional second argument, which defaults to "building".

comment:2 Changed 3 years ago by mkoeppe

Description: modified (diff)

comment:3 Changed 3 years ago by mkoeppe

Branch: u/mkoeppe/spkg_check_in__do_not_use_sdh_make_to_do__make_check_

comment:4 Changed 3 years ago by mkoeppe

Commit: 2c647fca4d4a84f77fdb5fabaef752b0ac2bd92e
Description: modified (diff)

New commits:

2c647fcbuild/pkgs/*/spkg-check.in: Do not print misleading error messages: avoid sdh_make

comment:5 Changed 3 years ago by mkoeppe

Authors: Matthias Koeppe
Status: newneeds_review

comment:6 Changed 3 years ago by mkoeppe

Summary: spkg-check.in: Do not use sdh_make to do 'make check'spkg-check.in: Do not use sdh_make to do 'make check', to avoid misleading messages

comment:7 Changed 3 years ago by dimpase

maybe, for uniformity, not "Failures checking $PKG_NAME", but "Error checking $PKG_NAME"

comment:8 Changed 3 years ago by mkoeppe

I worded it like this because if SAGE_CHECK=warn, then it is not an error but only a warning.

comment:9 Changed 3 years ago by git

Commit: 2c647fca4d4a84f77fdb5fabaef752b0ac2bd92e67256c2607174d502aba8cd7a1e56a37238be4aa

Branch pushed to git repo; I updated commit sha1. New commits:

67256c2Use 'failures', not 'error' when reporting testsuite failures

comment:10 Changed 3 years ago by git

Commit: 67256c2607174d502aba8cd7a1e56a37238be4aac53ddc71444cebbe3ae99f43d825471d3c58e766

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

251ab47trac 29492: remove outdated boilerplate from spkg-install.in,
1383a59Merge branch 'u/jhpalmieri/remove-boilerplate' of git://trac.sagemath.org/sage into t/29510/spkg_check_in__remove_messages_that_duplicate_sage_spkg_s_messages
2533a67build/pkgs/*/spkg-check.in: Remove messages that duplicate sage-spkg messages
9b213a4build/bin/sage-spkg: Add message when test suite passed
ca36a87build/pkgs/*/spkg-check.in: Do not print misleading error messages: avoid sdh_make
c53ddc7Use 'failures', not 'error' when reporting testsuite failures

comment:11 Changed 3 years ago by mkoeppe

Dependencies: #29510

rebased on top of #29510 to remove a merge conflict

comment:12 Changed 3 years ago by mkoeppe

needs review

comment:13 Changed 3 years ago by jhpalmieri

Reviewers: Dima Pasechnik, John Palmieri
Status: needs_reviewpositive_review

Looks good to me.

comment:14 Changed 3 years ago by mkoeppe

Thank you!

comment:15 Changed 3 years ago by vbraun

Branch: u/mkoeppe/spkg_check_in__do_not_use_sdh_make_to_do__make_check_c53ddc71444cebbe3ae99f43d825471d3c58e766
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.