Opened 3 years ago

Last modified 3 years ago

#29455 closed defect

Bug in incidence_matrix of CombinatorialPolyhedron — at Version 1

Reported by: Laith Rastanawi Owned by:
Priority: major Milestone: sage-9.1
Component: geometry Keywords: polytope, combinatorialpolyhedron, incidence_matrix
Cc: Jean-Philippe Labbé, gh-kliem Merged in:
Authors: Jonathan Kliem Reviewers:
Report Upstream: N/A Work issues:
Branch: public/29455 (Commits, GitHub, GitLab) Commit: 4aa8b28c0b64b5ad51f9f3a16bae3bf47f7a7b1e
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-kliem)

The incidence_matrix method of a 0-dimensional CombinatorialPolyhedron returns an error:

sage: P = Polyhedron([[0]]); P
A 0-dimensional polyhedron in ZZ^1 defined as the convex hull of 1 vertex
sage: C = P.combinatorial_polyhedron()
sage: C.incidence_matrix()
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-7-dab311ba238f> in <module>()
----> 1 C.incidence_matrix()
...
ValueError: ``output_dimension`` must be the dimension of proper faces

We fix this and make the 0-dimensional case consistent with Polyhedron_base.

Also we make incidence_matrix a chached_method.

Change History (1)

comment:1 Changed 3 years ago by gh-kliem

Authors: Jonathan Kliem
Branch: public/29455
Commit: 4aa8b28c0b64b5ad51f9f3a16bae3bf47f7a7b1e
Description: modified (diff)
Status: newneeds_review

New commits:

4aa8b28fix incidence matrix for small combinatorial polyhedra
Note: See TracTickets for help on using tickets.