Detect and use the system fflas-ffpack

[mjo]

This package already has an spkg-configure.m4 file and some distro information, but we can't yet detect and use the system copy. Here's hoping everyone ships the pkg-config file.

[mjo]

Here's a go at this. I picked the lower version bound based on what Debian has on repology.

---

New commits:

​4cada3f	Trac #29453: use PKG_CHECK_MODULES to find a system fflas-ffpack.
​5ce8498	Trac #29453: add Gentoo package information for fflas-ffpack.

[mjo]

Eh, I see what's going on with the MP library stuff. Sage is installing MPIR but with everything named "gmp", so having the mpir SPKG installed does satisfy a "gmp" dependency. I'll have to add mpir to the DEPCHECK.

[mjo]

Oh, I accidentally got this one right.

[mkoeppe]

"Warning: this doesn't get executed with --without-system-fflas-ffpack" ... can this be fixed?

[mjo]

Replying to mkoeppe:

"Warning: this doesn't get executed with --without-system-fflas-ffpack" ... can this be fixed?

The issue is already addressed upstream (but not in a release) by detecting support for -march=native and using that instead of a million individual flags. So reporting it upstream isn't going to do any good.

Option 1: I could move that code to the top-level configure.ac. I think it will serve its purpose there, although it will be a bit out of place.

Option 2: we could just disable those flags in spkg-install, and use #27122 to add back -march=native.

Option 3: leave it where it is, and count on the fact that nobody will want to build an extra copy of fflas-ffpack.

[mkoeppe]

Maybe just move to the PRE or POST argument of SAGE_SPKG_CONFIGURE(PACKAGE-NAME,[CHECK],[REQUIRED-CHECK],[PRE],[POST])

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​88c1717

Trac #29453: detect compiler flags in spkg-configure's POST phase.

[mjo]

Replying to mkoeppe:

Maybe just move to the PRE or POST argument of SAGE_SPKG_CONFIGURE(PACKAGE-NAME,[CHECK],[REQUIRED-CHECK],[PRE],[POST])

Good idea, done.

[mkoeppe]

Tests run at ​https://github.com/mkoeppe/sage/actions/runs/73584944

[mkoeppe]

debian, fedora seem to work

Should add arch: fflas-ffpack and conda: fflas-ffpack

[mjo]

Replying to mkoeppe:

Should add arch: fflas-ffpack and conda: fflas-ffpack

Can you just add them? I really don't want to sit through another rebuild after git checkout to add two lines of text =)

[mkoeppe]

Sure, will do

[mkoeppe]

Tests at ​https://github.com/mkoeppe/sage/actions/runs/73955490

---

New commits:

​a917baa

build/pkgs/fflas_ffpack/distros: Add more distributions

[dimpase]

This does not work on Debian buster, as linbox needs a fresher fflas-ffpack:

checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for FFLAS_FFPACK... no
configure: error: Package requirements (fflas-ffpack >= 2.4.0) were not met:

Requested 'fflas-ffpack >= 2.4.0' but version of fflas-ffpack is 2.3.2
You may find new versions of fflas-ffpack at http://github.com/linbox-team/fflas-ffpack

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables FFLAS_FFPACK_CFLAGS
and FFLAS_FFPACK_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
****************************************************************************************************************************************************
Error configuring linbox-1.6.3

[mjo]

Replying to dimpase:

This does not work on Debian buster, as linbox needs a fresher fflas-ffpack:

I guess I'll have to update the minimum version for now. When we're able to use the system linbox, we might be able to accept an older fflas-ffpack again. I'll open the linbox ticket now so we don't forget.

[mjo]

I opened #29484 for linbox, and set the bound on fflas-ffpack to 2.4.0 for now.

---

New commits:

​56567ac	Trac #29453: require at least fflas-ffpack-2.4.0.
​bdac4ba	build/pkgs/fflas_ffpack/distros: Add more distributions

[mkoeppe]

This seems to work well (​https://github.com/mkoeppe/sage/actions/runs/75739694). Only very new distributions have a sufficiently new version, of course.

By the way, on debian-buster-standard system fflas_ffpack is already not used because its dependency givaro is too old.