Opened 6 months ago

Closed 6 months ago

#29452 closed defect (fixed)

Pickling Frobenius endomorphism is broken

Reported by: caruso Owned by:
Priority: major Milestone: sage-9.1
Component: finite rings Keywords: pickling
Cc: Merged in:
Authors: Xavier Caruso Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 16ce9e3 (Commits) Commit: 16ce9e30fc30589e8a7a9621e325d42b15722079
Dependencies: Stopgaps:

Description 

sage: k.<a> = GF(5^3)
sage: Frob = k.frobenius_endomorphism()
sage: Frob
Frobenius endomorphism a |--> a^5 on Finite Field in a of size 5^3
sage: loads(dumps(Frob))
Identity endomorphism of Finite Field in a of size 5^3

Change History (6)

comment:1 Changed 6 months ago by caruso

  • Branch set to u/caruso/pickling_frobenius

comment:2 Changed 6 months ago by caruso

  • Authors set to Xavier Caruso
  • Commit set to 8f40b0a7c09ccd3e4751a7301d7ef4491c474581
  • Status changed from new to needs_review

Here is a fix.

New commits:

​8f40b0afix pickling for Frobenius endomorphisms

comment:3 Changed 6 months ago by git

  • Commit changed from 8f40b0a7c09ccd3e4751a7301d7ef4491c474581 to cb588b8ebbb0190accaf5b871064a487f0117181

Branch pushed to git repo; I updated commit sha1. New commits:

​cb588b8fix pickling for embeddings

comment:4 Changed 6 months ago by git

  • Commit changed from cb588b8ebbb0190accaf5b871064a487f0117181 to 16ce9e30fc30589e8a7a9621e325d42b15722079

Branch pushed to git repo; I updated commit sha1. New commits:

​16ce9e3add testsuite

comment:5 Changed 6 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Indeed the domain should always be finite since it is a finite field morphism. LGTM.

comment:6 Changed 6 months ago by vbraun

  • Branch changed from u/caruso/pickling_frobenius to 16ce9e30fc30589e8a7a9621e325d42b15722079
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.