Opened 13 months ago
Closed 12 months ago
#29440 closed enhancement (fixed)
Improve doctests of Degenerate Submanifold
Reported by: | gh-kliem | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.1 |
Component: | geometry | Keywords: | degenerate manifolds, doctests |
Cc: | Dicolevrai, egourgoulhon, mkoeppe | Merged in: | |
Authors: | Jonathan Kliem | Reviewers: | Hans Fotsing Tetsing |
Report Upstream: | N/A | Work issues: | |
Branch: | 848fec0 (Commits, GitHub, GitLab) | Commit: | 848fec03b635a9f044b4f3daf39f45538a3f421e |
Dependencies: | Stopgaps: |
Description
The doctests in sage -t src/sage/manifolds/differentiable/degenerate_submanifold.py
have problems with time outs.
See for example:
- https://trac.sagemath.org/ticket/29104#comment:61
- https://groups.google.com/d/msg/sage-release/eMQIlhglN98/bTwDGD9HBQAJ
- https://trac.sagemath.org/ticket/27122#comment:33
Part of the problem might be, that the file makes no use of long time
flags (testing takes 86 seconds on a fast computer without --long
).
We add those flags and some smaller examples to display functionality of the module. This brings down testing time without --long
` to less than 30 seconds.
Change History (8)
comment:1 Changed 13 months ago by
- Branch set to public/29440
- Commit set to ef94ca59cc368c858958e408dcfa27c6ea05cd0c
comment:2 Changed 13 months ago by
- Status changed from new to needs_review
comment:3 Changed 13 months ago by
- Commit changed from ef94ca59cc368c858958e408dcfa27c6ea05cd0c to 848fec03b635a9f044b4f3daf39f45538a3f421e
Branch pushed to git repo; I updated commit sha1. New commits:
848fec0 | removed redundant import
|
comment:4 in reply to: ↑ description Changed 13 months ago by
- Status changed from needs_review to positive_review
Replying to gh-kliem:
The doctests in
sage -t src/sage/manifolds/differentiable/degenerate_submanifold.py
have problems with time outs.See for example:
- https://trac.sagemath.org/ticket/29104#comment:61
- https://groups.google.com/d/msg/sage-release/eMQIlhglN98/bTwDGD9HBQAJ
- https://trac.sagemath.org/ticket/27122#comment:33
Part of the problem might be, that the file makes no use of
long time
flags (testing takes 86 seconds on a fast computer without--long
).We add those flags and some smaller examples to display functionality of the module. This brings down testing time without
--long
` to less than 30 seconds.
Thank you so much for the improvement and the example!
comment:5 Changed 13 months ago by
please add missing reviewer full name
comment:6 Changed 13 months ago by
- Reviewers set to Hans Fotsing Tetsing
comment:7 Changed 13 months ago by
comment:8 Changed 12 months ago by
- Branch changed from public/29440 to 848fec03b635a9f044b4f3daf39f45538a3f421e
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
use # long time and add a smaller example