Opened 16 months ago

Closed 16 months ago

#29440 closed enhancement (fixed)

Improve doctests of Degenerate Submanifold

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.1
Component: geometry Keywords: degenerate manifolds, doctests
Cc: Dicolevrai, egourgoulhon, mkoeppe Merged in:
Authors: Jonathan Kliem Reviewers: Hans Fotsing Tetsing
Report Upstream: N/A Work issues:
Branch: 848fec0 (Commits, GitHub, GitLab) Commit: 848fec03b635a9f044b4f3daf39f45538a3f421e
Dependencies: Stopgaps:

Status badges

Description

The doctests in sage -t src/sage/manifolds/differentiable/degenerate_submanifold.py have problems with time outs.

See for example:

Part of the problem might be, that the file makes no use of long time flags (testing takes 86 seconds on a fast computer without --long).

We add those flags and some smaller examples to display functionality of the module. This brings down testing time without --long` to less than 30 seconds.

Change History (8)

comment:1 Changed 16 months ago by gh-kliem

  • Branch set to public/29440
  • Commit set to ef94ca59cc368c858958e408dcfa27c6ea05cd0c

New commits:

​ef94ca5use # long time and add a smaller example

comment:2 Changed 16 months ago by gh-kliem

  • Status changed from new to needs_review

comment:3 Changed 16 months ago by git

  • Commit changed from ef94ca59cc368c858958e408dcfa27c6ea05cd0c to 848fec03b635a9f044b4f3daf39f45538a3f421e

Branch pushed to git repo; I updated commit sha1. New commits:

​848fec0removed redundant import

comment:4 in reply to: ↑ description Changed 16 months ago by Dicolevrai

  • Status changed from needs_review to positive_review

Replying to gh-kliem:

The doctests in sage -t src/sage/manifolds/differentiable/degenerate_submanifold.py have problems with time outs.

See for example:

Part of the problem might be, that the file makes no use of long time flags (testing takes 86 seconds on a fast computer without --long).

We add those flags and some smaller examples to display functionality of the module. This brings down testing time without --long` to less than 30 seconds.

Thank you so much for the improvement and the example!

comment:5 Changed 16 months ago by chapoton

please add missing reviewer full name

comment:6 Changed 16 months ago by Dicolevrai

  • Authors Jonathan Kliem deleted
  • Reviewers set to Hans Fotsing Tetsing

comment:7 Changed 16 months ago by gh-kliem

  • Authors set to Jonathan Kliem

comment:8 Changed 16 months ago by vbraun

  • Branch changed from public/29440 to 848fec03b635a9f044b4f3daf39f45538a3f421e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.