Opened 2 years ago

Closed 2 years ago

#29438 closed defect (fixed)

Fix singular build error on local-debian-conda-forge-standard

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.1
Component: packages: standard Keywords:
Cc: Dima Pasechnik, Isuru Fernando Merged in:
Authors: Isuru Fernando Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 0eec02e (Commits, GitHub, GitLab) Commit: 0eec02ed50df07aaa990430daff439ae25d5ce1a
Dependencies: Stopgaps:

Status badges

Description

From #29415:

groebnerCone.cc: In member function 'groebnerCones groebnerCone::tropicalNeighbours() const':
groebnerCone.cc:449:13: error: 'pointsOutwards' was not declared in this scope
         if (pointsOutwards(ray[j]))
             ^~~~~~~~~~~~~~
make[9]: *** [Makefile:726: gfanlib_la-groebnerCone.lo] Error 1
this is on Debian, and might be due to using gfan

workaround is to do export CPPFLAGS="$CPPFLAGS -UNDEBUG" in Singular build script.

Change History (6)

comment:2 Changed 2 years ago by Isuru Fernando

Authors: Isuru Fernando
Branch: u/isuruf/29348
Commit: 0eec02ed50df07aaa990430daff439ae25d5ce1a
Status: newneeds_review

New commits:

0eec02eFix building singular with -DNDEBUG

comment:3 Changed 2 years ago by Dima Pasechnik

is this backporting of an upstream patch?

comment:4 Changed 2 years ago by Dima Pasechnik

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

lgtm

comment:6 Changed 2 years ago by Volker Braun

Branch: u/isuruf/293480eec02ed50df07aaa990430daff439ae25d5ce1a
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.