#29432 closed enhancement (fixed)

Improve Localization

Reported by: soehms Owned by:
Priority: major Milestone: sage-9.2
Component: commutative algebra Keywords: integral domain localization
Cc: tscrim Merged in:
Authors: Sebastian Oehms Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 5956860 (Commits, GitHub, GitLab) Commit: 5956860faa57b8ddfab19b34d9838538cd553f6c
Dependencies: Stopgaps:

Status badges

Description (last modified by soehms)

Localization of integral domains has been introduced in ticket #28862. The aime of this ticket is to have localizations behave well in more contexts. Therefore, a couple of generically used methods are added to the class such as __hash__, _rational_, _integer_ and is_field.

Change History (8)

comment:1 Changed 14 months ago by soehms

  • Branch set to u/soehms/improve_localization_29432

comment:2 Changed 14 months ago by soehms

  • Commit set to 5956860faa57b8ddfab19b34d9838538cd553f6c
  • Status changed from new to needs_review

I implement the methods listed in the description.


New commits:

595686029432: initial version

comment:3 Changed 14 months ago by soehms

  • Type changed from PLEASE CHANGE to enhancement

comment:4 Changed 14 months ago by soehms

  • Authors set to Sebastian Oehms
  • Cc tscrim added
  • Description modified (diff)

comment:5 Changed 13 months ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-9.2

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

comment:6 Changed 12 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM. (Sorry I lost track of this ticket.)

comment:7 Changed 12 months ago by soehms

Thanks!

comment:8 Changed 12 months ago by vbraun

  • Branch changed from u/soehms/improve_localization_29432 to 5956860faa57b8ddfab19b34d9838538cd553f6c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.