Opened 2 years ago
Closed 2 years ago
#29430 closed enhancement (fixed)
spkgconfigure.m4 for flintqs
Reported by:  mjo  Owned by:  

Priority:  major  Milestone:  sage9.1 
Component:  build: configure  Keywords:  
Cc:  dimpase, embray, mkoeppe, fbissey  Merged in:  
Authors:  Michael Orlitzky  Reviewers:  Matthias Koeppe, Dima Pasechnik 
Report Upstream:  N/A  Work issues:  
Branch:  5990654 (Commits, GitHub, GitLab)  Commit:  5990654aa3f16aed4e28425e4f0f64ddf7ea9902 
Dependencies:  Stopgaps: 
Description
This package only installs the QuadraticSieve
executable, which needs to be in the PATH
for qsieve()
to work in Sage.
Change History (30)
comment:1 Changed 2 years ago by
 Branch set to u/mjo/ticket/29430
 Commit set to 580c0ee678f3c04e191613256921c05e4dfa83a9
 Status changed from new to needs_review
comment:3 Changed 2 years ago by
 Commit changed from 580c0ee678f3c04e191613256921c05e4dfa83a9 to 2b1e41b0bc0041028e7576d29c4b0d014fbe1685
Branch pushed to git repo; I updated commit sha1. New commits:
2b1e41b  Trac #29430: add distros/* information for flintqs.

comment:4 Changed 2 years ago by
 Status changed from needs_work to needs_review
I added debian, fedora, and gentoo (I added the Gentoo package a few seconds before opening this ticket) based on repology.org results. Ubuntu and nix have packages too, but I don't see ubuntu.txt or nix.txt anywhere in the tree.
comment:5 Changed 2 years ago by
ubuntu uses debian.txt
comment:6 Changed 2 years ago by
See #29130 for nix
comment:7 Changed 2 years ago by
Have you checked arch?
comment:8 Changed 2 years ago by
on conda it's flintqs
too.
comment:9 Changed 2 years ago by
and on arch, cf https://www.archlinux.org/packages/community/x86_64/flintqs/
comment:10 Changed 2 years ago by
Fedora does not have flintqs
comment:11 Changed 2 years ago by
 Commit changed from 2b1e41b0bc0041028e7576d29c4b0d014fbe1685 to b34335174b52d8377aa8bbe22c145b70bfb09f54
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
b343351  Trac #29430: add distros/* information for flintqs.

comment:12 Changed 2 years ago by
Force pushed a rename fedora > conda. The arch.txt was already there (before I added the m4 file).
comment:13 Changed 2 years ago by
 Reviewers set to Matthias Koeppe, Dima Pasechnik
 Status changed from needs_review to positive_review
lgtm  but add author's name
comment:14 Changed 2 years ago by
comment:15 Changed 2 years ago by
 Status changed from positive_review to needs_review
Let me run some tests first.
comment:16 Changed 2 years ago by
well, I did test on Debian. There is basically one version of this packages around.
comment:17 Changed 2 years ago by
 Status changed from needs_review to positive_review
comment:18 Changed 2 years ago by
 Status changed from positive_review to needs_work
Sorry, I'll have to add "mpir" to the DEPCHECK here. I didn't realize sage installed it in place of gmp with everything renamed mpir>gmp.
comment:19 Changed 2 years ago by
you need to check for BOTH gmp and mpir, not just one of them.
comment:20 Changed 2 years ago by
e.g.
SAGE_SPKG_CONFIGURE([givaro], [ m4_pushdef([SAGE_GIVARO_MINVER],["40101"]) SAGE_SPKG_DEPCHECK([gmp mpir], [ ...
comment:21 Changed 2 years ago by
Thanks, I see that now. I was rather confused about how all these packages explicitly looking for libgmp in ./configure could use MPIR in sage. I'm halfway through a build test for a ppl spkgconfigure but as soon as it finishes I'll fix this up.
comment:22 Changed 2 years ago by
 Branch changed from u/mjo/ticket/29430 to public/packages/flintqsconfig
 Commit changed from b34335174b52d8377aa8bbe22c145b70bfb09f54 to 1fdea6a54fe90ba109ed1b40d1526256a9c3a342
 Status changed from needs_work to needs_review
comment:24 Changed 2 years ago by
If this only installs an executable, I don't think we need any depcheck at all because there cannot be a library conflict.
comment:25 Changed 2 years ago by
 Status changed from positive_review to needs_info
comment:26 followup: ↓ 27 Changed 2 years ago by
The QuadraticSieve
executable is the only thing used, and if it exists on the system, it should work fine.. does anyone philosophically object if withoutsystemgmp
(or mpir) is ignored for some packages?
comment:27 in reply to: ↑ 26 Changed 2 years ago by
Replying to mjo:
does anyone philosophically object if
withoutsystemgmp
(or mpir) is ignored for some packages?
I don't think this is a concern.
comment:28 Changed 2 years ago by
 Branch changed from public/packages/flintqsconfig to u/mjo/ticket/29430
 Commit changed from 1fdea6a54fe90ba109ed1b40d1526256a9c3a342 to 5990654aa3f16aed4e28425e4f0f64ddf7ea9902
 Status changed from needs_info to needs_review
comment:29 Changed 2 years ago by
 Status changed from needs_review to positive_review
comment:30 Changed 2 years ago by
 Branch changed from u/mjo/ticket/29430 to 5990654aa3f16aed4e28425e4f0f64ddf7ea9902
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Trac #29430: new spkgconfigure.m4 for flintqs.