Opened 2 years ago

Closed 21 months ago

#29412 closed enhancement (fixed)

Deprecate cotangent methods named "cotan" to "cot"

Reported by: gh-DaveWitteMorris Owned by:
Priority: minor Milestone: sage-9.2
Component: numerical Keywords: cotangent, complex
Cc: Merged in:
Authors: Dave Morris Reviewers: Markus Wageringel
Report Upstream: N/A Work issues:
Branch: b78b409 (Commits, GitHub, GitLab) Commit: b78b409f3ec0958c2b59012fbc8da34ca092f5ad
Dependencies: #29409 Stopgaps:

Status badges


Most of sage uses cot for the cotangent function 1/tan(x), but the classes ComplexNumber and MPComplexNumber have methods that are called cotan, instead. To eliminate a bug caused by this inconsistency, ticket #29409 renames these methods to cot.

For backward compatibility, ticket #29409 defines cotan as an alias for cot in these two classes. This ticket deprecates those aliases.

FWIW, Maple uses cot and Mathematica uses Cot.

Change History (9)

comment:1 Changed 2 years ago by gh-DaveWitteMorris

  • Branch set to public/29412

comment:2 Changed 2 years ago by gh-DaveWitteMorris

  • Commit set to 6259014a4234a4d89abe228028d9c4610ee91b42
  • Status changed from new to needs_review

New commits:

9b59968change cotan to tan
6259014deprecate cotan

comment:3 Changed 2 years ago by gh-DaveWitteMorris

  • Authors set to Dave Morris

comment:4 Changed 2 years ago by git

  • Commit changed from 6259014a4234a4d89abe228028d9c4610ee91b42 to b78b409f3ec0958c2b59012fbc8da34ca092f5ad

Branch pushed to git repo; I updated commit sha1. New commits:

b941d30include ticket number in comments
b78b409Merge ticket #29409

comment:5 Changed 2 years ago by gh-DaveWitteMorris

To avoid a merge conflict, I merged with #29409, but that makes no changes to the files in this branch. (The lines that changed in #29409 are exactly the ones that this ticket replaces with deprecations.)

comment:6 Changed 2 years ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-9.2

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

comment:7 Changed 21 months ago by gh-mwageringel

  • Reviewers set to Markus Wageringel
  • Status changed from needs_review to positive_review

This looks good to me.

comment:8 Changed 21 months ago by gh-DaveWitteMorris

Thanks for the review!

comment:9 Changed 21 months ago by vbraun

  • Branch changed from public/29412 to b78b409f3ec0958c2b59012fbc8da34ca092f5ad
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.