Opened 2 years ago
Last modified 4 months ago
#29410 new enhancement
Combinatorial designs: add some difference matrices and related objects — at Version 5
Reported by:  ghIvoMaffei  Owned by:  

Priority:  major  Milestone:  sage9.7 
Component:  combinatorics  Keywords:  symmetric_nets orthogonal_arrays transversal_designs difference_matrices 
Cc:  dimpase, slelievre  Merged in:  
Authors:  Ivo Maffei  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  u/ghIvoMaffei/symmetric_nets (Commits, GitHub, GitLab)  Commit:  6c362d817d58b2b7db17f1420ddaf78a7cd6d20b 
Dependencies:  Stopgaps: 
Description (last modified by )
We add a few constructions of difference matrices whose lambda parameter is not 1.
We then modify the orthogonal arrays and transversal designs constructions
to take advantage of these additions. Finally, we add a new function symmetric_net
.
Change History (5)
comment:1 Changed 2 years ago by
comment:2 Changed 2 years ago by
 Commit changed from 5cd8a3c3671efc12e6a511a1b79c854111f0b296 to 6c362d817d58b2b7db17f1420ddaf78a7cd6d20b
Branch pushed to git repo; I updated commit sha1. New commits:
6c362d8  fixed old doctests and bugs

comment:3 Changed 2 years ago by
Do you run tests using GitHub Actions? (see #29401 for details)
In your code, to build docs, one needs

src/sage/combinat/designs/orthogonal_arrays.py
a b def symmetric_net(n, lmbda=1, check=True, existence=False): 80 80 Set to ``True`` by default 81 81 82 82  ``existence``  bolean. Instead of returnig a symmetric net, return: 83  ``True``  such a net can be constructed by Sage84  ``False``  no such a net exists85  ``Unknown``  Sage does not know how to build such a design86 so such design may or may not exist83  ``True``  such a net can be constructed by Sage 84  ``False``  no such a net exists 85  ``Unknown``  Sage does not know how to build such a design 86 so such design may or may not exist 87 87 88 88 EXAMPLES:: 89 89 
src/sage/combinat/designs/difference_matrices.py
a b def subgroup_construction(g,k,lmbda,existence=False): 428 428  ``g,k,\lambda``  (integers) parameters of the difference matrix to construct 429 429 430 430  ``existence``  (boolean) instead of building the design, return: 431  ``True`` if Sage can build the difference matrix using the subgroup construction432  ``False`` if Sage can't build the difference matrix using this construction433 Note that Sage may be able to build such difference matrix in other ways431  ``True`` if Sage can build the difference matrix using the subgroup construction 432  ``False`` if Sage can't build the difference matrix using this construction 433 Note that Sage may be able to build such difference matrix in other ways 434 434 435 435 EXAMPLES:: 436 436
(sphinx is very sensitive to correct indentation)
comment:4 Changed 2 years ago by
 Milestone changed from sage9.1 to sage9.2
Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.
comment:5 Changed 2 years ago by
 Cc slelievre added
 Description modified (diff)
 Summary changed from Addition of some difference matrices and all related objects to Combinatorial designs: add some difference matrices and related objects
One occurrence of "more than 1 time" should be "more than once" as elsewhere.
Can you do a round of pep8 formatting?
I would use lamda
as an alternate name for lambda
(since lambda is a reserved keyword in Python).
I find it makes code easier to read than lambd or lmbda.
I see failing doctests: