Opened 3 months ago

Closed 2 months ago

#29383 closed enhancement (fixed)

Remove obsolete scripts from src/bin/

Reported by: mkoeppe Owned by:
Priority: minor Milestone: sage-9.1
Component: scripts Keywords:
Cc: jhpalmieri, dimpase, mjo Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: f7f34ff (Commits) Commit: f7f34ff14e9146b6fe7d404eb2f2faa203e6fb99
Dependencies: Stopgaps:

Description

  • sage-README-osx.txt # see #25995, #21570
  • sage-pkg # a script to create old-style spkgs
  • sage-unzip # unused

(Part of #21559.)

Change History (14)

comment:1 Changed 3 months ago by mkoeppe

  • Branch set to u/mkoeppe/remove_obsolete_scripts_from_src_bin_

comment:2 Changed 3 months ago by mkoeppe

  • Commit set to f7f34ff14e9146b6fe7d404eb2f2faa203e6fb99
  • Status changed from new to needs_review

New commits:

55430bddelete src/bin/sage-README-osx.txt
6fe5012Remove obsolete script sage-pkg (creates old-style spkg archives)
f7f34ffsrc/bin/sage-unzip: Remove (unused script)

comment:3 Changed 3 months ago by dimpase

remind me, what's the new way to make user packages for Sage?

comment:4 Changed 3 months ago by jhpalmieri

Create the appropriate subdirectory of build/pkgs and populate with checksums.ini, etc.

comment:5 Changed 3 months ago by jhpalmieri

But there is no non-deprecated way for someone to create a standalone package which is not part of Sage, I think.

comment:6 Changed 3 months ago by mkoeppe

That's right

comment:7 Changed 3 months ago by jhpalmieri

It works for me. Is it okay to remove the only way to create standalone user packages, even if it is deprecated? It's not even documented anywhere. I say we merge this. Or do we need to ask on sage-devel?

comment:8 Changed 3 months ago by mkoeppe

The discussion on sage-devel happened already, leading to the deprecatIon.

comment:9 follow-up: Changed 3 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

ok - I assume you checked that this is not in docs any more, either.

comment:10 Changed 3 months ago by mkoeppe

Thanks!

comment:11 in reply to: ↑ 9 ; follow-up: Changed 2 months ago by mkoeppe

Replying to dimpase:

ok - I assume you checked that this is not in docs any more, either.

Removing the chapter where it appears in #29289

comment:12 in reply to: ↑ 11 ; follow-up: Changed 2 months ago by jhpalmieri

Replying to mkoeppe:

Replying to dimpase:

ok - I assume you checked that this is not in docs any more, either.

Removing the chapter where it appears in #29289

Or maybe #29406?

comment:13 in reply to: ↑ 12 Changed 2 months ago by mkoeppe

Replying to jhpalmieri:

Replying to mkoeppe:

Replying to dimpase:

ok - I assume you checked that this is not in docs any more, either.

Removing the chapter where it appears in #29289

Or maybe #29406?

You're right.

comment:14 Changed 2 months ago by vbraun

  • Branch changed from u/mkoeppe/remove_obsolete_scripts_from_src_bin_ to f7f34ff14e9146b6fe7d404eb2f2faa203e6fb99
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.