Opened 3 years ago
Closed 3 years ago
#29373 closed defect (fixed)
Upgrade freetype to 2.10.1 to fix installation on slackware-14.2
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.1 |
Component: | packages: standard | Keywords: | |
Cc: | slelievre, dimpase, fbissey, charpent, gh-kliem | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Jonathan Kliem |
Report Upstream: | N/A | Work issues: | |
Branch: | f7683c7 (Commits, GitHub, GitLab) | Commit: | f7683c7b044abe590bd5a54c7ed11183d9f6ffb2 |
Dependencies: | Stopgaps: |
Description (last modified by )
freetype fails to install on slackware-14.2-minimal
, as can be seen at
https://github.com/mkoeppe/sage/runs/520449598 (via #29354):
./builds/unix/libtool --tag=RC --mode=compile windres -o /sage/local/var/tmp/sage/build/freetype-2.9.1/src/objs/ftver.lo /sage/local/var/tmp/sage/build/freetype-2.9.1/src/src/base/ftver.rc libtool: compile: windres /sage/local/var/tmp/sage/build/freetype-2.9.1/src/src/base/ftver.rc -o /sage/local/var/tmp/sage/build/freetype-2.9.1/src/objs/.libs/ftver.o /sage/local/var/tmp/sage/build/freetype-2.9.1/src/src/base/ftver.rc:19:20: fatal error: windows.h: No such file or directory compilation terminated. windres: preprocessing failed.
The upgrade to 2.10.1 fixes it. The upstream tarball URL is in checksums.ini. To test the update on this branch: Use make SAGE_SPKG="sage-spkg -o" freetype
; this will download the new upstream package automatically.
Change History (23)
comment:1 Changed 3 years ago by
Branch: | → u/mkoeppe/freetype_installation_fails_on_slackware_14_2 |
---|
comment:2 Changed 3 years ago by
Commit: | → 2e2e77f47589e7b29f88b96f42f371e63a20c4f4 |
---|
comment:3 Changed 3 years ago by
Authors: | → Matthias Koeppe |
---|---|
Description: | modified (diff) |
Status: | new → needs_review |
Summary: | freetype installation fails on slackware-14.2 → Upgrade freetype to 2.10.1 to fix installation on slackware-14.2 |
comment:4 Changed 3 years ago by
comment:5 Changed 3 years ago by
Status: | needs_review → needs_work |
---|
these tests are pretty much a waste, as the package is not yet on Sage's mirrors, and thus its installation fails. One should have used the new feature with an explcit URL to download from.
comment:6 follow-up: 8 Changed 3 years ago by
the testing framework also needs a feature to force using particular non-system packages, as every "standard" run with freetype available from the system does not do anything meaningful here.
comment:7 follow-up: 9 Changed 3 years ago by
The new Upstream URL feature is used in these tests, and it's working. What are you looking at?
comment:8 Changed 3 years ago by
comment:9 Changed 3 years ago by
Replying to mkoeppe:
The new Upstream URL feature is used in these tests, and it's working. What are you looking at?
2020-03-22T08:03:02.1567136Z Attempting to download from https://download.savannah.gnu.org/releases/freetype/freetype-2.10.1.tar.gz 2020-03-22T08:03:02.1567310Z [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx] 2020-03-22T08:03:02.1567461Z ERROR [transfer|run:135]: [Errno socket error] [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed
now I see that it's a different kind of problem, sorry - but still a problem.
comment:10 follow-up: 11 Changed 3 years ago by
probably instead of using something meaninful (wget is able to get the file just fine), it uses an improperly set Python-based downloader.
This might be a slackware-specific issue, though.
comment:11 Changed 3 years ago by
Status: | needs_work → needs_review |
---|
comment:13 Changed 3 years ago by
Commit: | 2e2e77f47589e7b29f88b96f42f371e63a20c4f4 → f7683c7b044abe590bd5a54c7ed11183d9f6ffb2 |
---|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
f7683c7 | Update freetype to 2.10.1, add upstream_url
|
comment:16 follow-up: 17 Changed 3 years ago by
This seems to solve the problem for slackware standard install.
For minimal install it fails to build git for some reason.
https://github.com/kliem/sage-test-27122/actions/runs/68003296.
I can also confirm that the upgrade works fine on debian buster and sage -t --all
passes.
comment:17 Changed 3 years ago by
comment:18 Changed 3 years ago by
Reviewers: | → Jonathan Kliem |
---|
Is there anything to pay attention to?
LGTM.
comment:19 Changed 3 years ago by
I guess one needs to check that the update does not break plotting.
comment:20 Changed 3 years ago by
Ok. I ran https://matplotlib.org/contents.html and https://matplotlib.org/3.1.0/tutorials/text/mathtext.html with and without upgrade and I don't see a difference.
comment:22 Changed 3 years ago by
Status: | needs_review → positive_review |
---|
comment:23 Changed 3 years ago by
Branch: | u/mkoeppe/freetype_installation_fails_on_slackware_14_2 → f7683c7b044abe590bd5a54c7ed11183d9f6ffb2 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits: