Opened 3 years ago

Closed 3 years ago

#29373 closed defect (fixed)

Upgrade freetype to 2.10.1 to fix installation on slackware-14.2

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.1
Component: packages: standard Keywords:
Cc: slelievre, dimpase, fbissey, charpent, gh-kliem Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: f7683c7 (Commits, GitHub, GitLab) Commit: f7683c7b044abe590bd5a54c7ed11183d9f6ffb2
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

freetype fails to install on slackware-14.2-minimal, as can be seen at https://github.com/mkoeppe/sage/runs/520449598 (via #29354):

./builds/unix/libtool --tag=RC --mode=compile windres -o /sage/local/var/tmp/sage/build/freetype-2.9.1/src/objs/ftver.lo /sage/local/var/tmp/sage/build/freetype-2.9.1/src/src/base/ftver.rc
libtool: compile:  windres /sage/local/var/tmp/sage/build/freetype-2.9.1/src/src/base/ftver.rc  -o /sage/local/var/tmp/sage/build/freetype-2.9.1/src/objs/.libs/ftver.o
/sage/local/var/tmp/sage/build/freetype-2.9.1/src/src/base/ftver.rc:19:20: fatal error: windows.h: No such file or directory
compilation terminated.
windres: preprocessing failed.

The upgrade to 2.10.1 fixes it. The upstream tarball URL is in checksums.ini. To test the update on this branch: Use make SAGE_SPKG="sage-spkg -o" freetype; this will download the new upstream package automatically.

Change History (23)

comment:1 Changed 3 years ago by mkoeppe

Branch: u/mkoeppe/freetype_installation_fails_on_slackware_14_2

comment:2 Changed 3 years ago by git

Commit: 2e2e77f47589e7b29f88b96f42f371e63a20c4f4

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

comment:3 Changed 3 years ago by mkoeppe

Authors: Matthias Koeppe
Description: modified (diff)
Status: newneeds_review
Summary: freetype installation fails on slackware-14.2Upgrade freetype to 2.10.1 to fix installation on slackware-14.2

comment:5 Changed 3 years ago by dimpase

Status: needs_reviewneeds_work

these tests are pretty much a waste, as the package is not yet on Sage's mirrors, and thus its installation fails. One should have used the new feature with an explcit URL to download from.

comment:6 Changed 3 years ago by dimpase

the testing framework also needs a feature to force using particular non-system packages, as every "standard" run with freetype available from the system does not do anything meaningful here.

comment:7 Changed 3 years ago by mkoeppe

The new Upstream URL feature is used in these tests, and it's working. What are you looking at?

comment:8 in reply to:  6 Changed 3 years ago by mkoeppe

Replying to dimpase:

the testing framework also needs a feature to force using particular non-system packages, as every "standard" run with freetype available from the system does not do anything meaningful here.

See #29367 EXTRA_CONFIGURE_ARGS

comment:9 in reply to:  7 Changed 3 years ago by dimpase

Replying to mkoeppe:

The new Upstream URL feature is used in these tests, and it's working. What are you looking at?

2020-03-22T08:03:02.1567136Z Attempting to download from https://download.savannah.gnu.org/releases/freetype/freetype-2.10.1.tar.gz
2020-03-22T08:03:02.1567310Z [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
2020-03-22T08:03:02.1567461Z ERROR [transfer|run:135]: [Errno socket error] [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed 

from here https://pipelines.actions.githubusercontent.com/4D1poTSDSSApU42GXYeGgQX6WjHwGPK9ZzdaE2SeHdlUs0ZBhW/_apis/pipelines/1/runs/241/signedlogcontent/54?urlExpires=2020-03-22T09%3A41%3A06.3755166Z&urlSigningMethod=HMACV1&urlSignature=lx22u7XIVAqXD3PUUbXYorDK9uZ%2BEcEZXa3P0435XeU%3D

now I see that it's a different kind of problem, sorry - but still a problem.

comment:10 Changed 3 years ago by dimpase

probably instead of using something meaninful (wget is able to get the file just fine), it uses an improperly set Python-based downloader.

This might be a slackware-specific issue, though.

Last edited 3 years ago by dimpase (previous) (diff)

comment:11 in reply to:  10 Changed 3 years ago by mkoeppe

Status: needs_workneeds_review

Replying to dimpase:

probably instead of using something meaninful (wget is able to get the file just fine), it uses an improperly set Python-based downloader.

This might be a slackware-specific issue, though.

Yes, thanks for spotting this. I'll try to fix this on #29354.

comment:12 Changed 3 years ago by mkoeppe

The download issues is fixed in #29354

comment:13 Changed 3 years ago by git

Commit: 2e2e77f47589e7b29f88b96f42f371e63a20c4f4f7683c7b044abe590bd5a54c7ed11183d9f6ffb2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f7683c7Update freetype to 2.10.1, add upstream_url

comment:14 Changed 3 years ago by mkoeppe

Rebased on 9.1.beta9, needs review

comment:15 Changed 3 years ago by mkoeppe

Cc: gh-kliem added

Still needs review

comment:16 Changed 3 years ago by gh-kliem

This seems to solve the problem for slackware standard install.

For minimal install it fails to build git for some reason.

https://github.com/kliem/sage-test-27122/actions/runs/68003296.

I can also confirm that the upgrade works fine on debian buster and sage -t --all passes.

comment:17 in reply to:  16 Changed 3 years ago by mkoeppe

Replying to gh-kliem:

For minimal install it fails to build git for some reason.

See #29424 for this.

comment:18 Changed 3 years ago by gh-kliem

Reviewers: Jonathan Kliem

Is there anything to pay attention to?

LGTM.

comment:19 Changed 3 years ago by mkoeppe

I guess one needs to check that the update does not break plotting.

comment:20 Changed 3 years ago by gh-kliem

Ok. I ran https://matplotlib.org/contents.html and https://matplotlib.org/3.1.0/tutorials/text/mathtext.html with and without upgrade and I don't see a difference.

comment:21 Changed 3 years ago by mkoeppe

Thanks very much!

comment:22 Changed 3 years ago by gh-kliem

Status: needs_reviewpositive_review

comment:23 Changed 3 years ago by vbraun

Branch: u/mkoeppe/freetype_installation_fails_on_slackware_14_2f7683c7b044abe590bd5a54c7ed11183d9f6ffb2
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.