Opened 3 years ago

Closed 3 years ago

#29368 closed enhancement (fixed)

remove files related to SageNB and deprecated function about temporary files

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.1
Component: refactoring Keywords:
Cc: arojas, fbissey, tscrim, jhpalmieri Merged in:
Authors: Frédéric Chapoton Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: efd3a40 (Commits, GitHub, GitLab) Commit: efd3a402f135d795c7ba1e72fe6e422780989817
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

  • remove deprecated function in temporary_file after #17234
  • remove two files related to the deprecated SageNB

Change History (11)

comment:1 Changed 3 years ago by chapoton

Branch: u/chapoton/29368
Commit: 414b3d92f9f96cdb2e05d1cd0ddc93e6ed70d20a
Status: newneeds_review

New commits:

414b3d9remove deprecated function from 17234

comment:2 Changed 3 years ago by chapoton

Summary: reomve deprecated function in temporary_fileremove deprecated function in temporary_file

comment:3 Changed 3 years ago by git

Commit: 414b3d92f9f96cdb2e05d1cd0ddc93e6ed70d20aefd3a402f135d795c7ba1e72fe6e422780989817

Branch pushed to git repo; I updated commit sha1. New commits:

efd3a40remove further traces of sagenb

comment:4 Changed 3 years ago by chapoton

Cc: arjoas fbissey tscrim jhpalmieri added

This is removing some files related to sagenb. Green is bot, please review.

comment:5 Changed 3 years ago by chapoton

Cc: arojas added; arjoas removed

comment:6 Changed 3 years ago by mkoeppe

Update ticket description please

comment:7 Changed 3 years ago by chapoton

Description: modified (diff)
Summary: remove deprecated function in temporary_fileremove files related to SageNB and deprecated function about temporary files

comment:8 Changed 3 years ago by jhpalmieri

I forget: are we supposed to support Python 2 in version 9.1? If so, I think we should keep these files until then, so the milestone should change to 9.2. If not, then I have no objections.

comment:9 Changed 3 years ago by chapoton

Given the discussion

https://groups.google.com/forum/#!topic/sage-devel/vYlbnAwKATM%5B51-75%5D

we make no promise of compatibility with py2, starting from 9.1 onwards. But we also try not to introduce incompatible code for some time. So the present ticket is ok, as it only removes code and moreover people should not expect to be able to use deprecated sageNB with the latest python3-enabled sage.

comment:10 Changed 3 years ago by jhpalmieri

Reviewers: John Palmieri
Status: needs_reviewpositive_review

Okay, looks good then.

comment:11 Changed 3 years ago by vbraun

Branch: u/chapoton/29368efd3a402f135d795c7ba1e72fe6e422780989817
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.