Opened 3 years ago
Closed 3 years ago
#29368 closed enhancement (fixed)
remove files related to SageNB and deprecated function about temporary files
| Reported by: | chapoton | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-9.1 |
| Component: | refactoring | Keywords: | |
| Cc: | arojas, fbissey, tscrim, jhpalmieri | Merged in: | |
| Authors: | Frédéric Chapoton | Reviewers: | John Palmieri |
| Report Upstream: | N/A | Work issues: | |
| Branch: | efd3a40 (Commits, GitHub, GitLab) | Commit: | efd3a402f135d795c7ba1e72fe6e422780989817 |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
- remove deprecated function in temporary_file after #17234
- remove two files related to the deprecated SageNB
Change History (11)
comment:1 Changed 3 years ago by
| Branch: | → u/chapoton/29368 |
|---|---|
| Commit: | → 414b3d92f9f96cdb2e05d1cd0ddc93e6ed70d20a |
| Status: | new → needs_review |
comment:2 Changed 3 years ago by
| Summary: | reomve deprecated function in temporary_file → remove deprecated function in temporary_file |
|---|
comment:3 Changed 3 years ago by
| Commit: | 414b3d92f9f96cdb2e05d1cd0ddc93e6ed70d20a → efd3a402f135d795c7ba1e72fe6e422780989817 |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| efd3a40 | remove further traces of sagenb
|
comment:4 Changed 3 years ago by
| Cc: | arjoas fbissey tscrim jhpalmieri added |
|---|
This is removing some files related to sagenb. Green is bot, please review.
comment:5 Changed 3 years ago by
| Cc: | arojas added; arjoas removed |
|---|
comment:7 Changed 3 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | remove deprecated function in temporary_file → remove files related to SageNB and deprecated function about temporary files |
comment:8 Changed 3 years ago by
I forget: are we supposed to support Python 2 in version 9.1? If so, I think we should keep these files until then, so the milestone should change to 9.2. If not, then I have no objections.
comment:9 Changed 3 years ago by
Given the discussion
https://groups.google.com/forum/#!topic/sage-devel/vYlbnAwKATM%5B51-75%5D
we make no promise of compatibility with py2, starting from 9.1 onwards. But we also try not to introduce incompatible code for some time. So the present ticket is ok, as it only removes code and moreover people should not expect to be able to use deprecated sageNB with the latest python3-enabled sage.
comment:10 Changed 3 years ago by
| Reviewers: | → John Palmieri |
|---|---|
| Status: | needs_review → positive_review |
Okay, looks good then.
comment:11 Changed 3 years ago by
| Branch: | u/chapoton/29368 → efd3a402f135d795c7ba1e72fe6e422780989817 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
New commits:
remove deprecated function from 17234