Opened 2 years ago

Closed 2 years ago

#29362 closed enhancement (fixed)

build/bin/sage-pip-install: Delegate to build/bin/sage-python23

Reported by: mkoeppe Owned by:
Priority: minor Milestone: sage-9.1
Component: build Keywords:
Cc: dimpase, jhpalmieri Merged in:
Authors: Matthias Koeppe Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 373ee9a (Commits, GitHub, GitLab) Commit: 373ee9a5042f021525dd0f4d4009f2d090c00589
Dependencies: Stopgaps:

Status badges

Description

This is to remove duplication of the dispatching logic.

(taken out from #29013)

Change History (5)

comment:1 Changed 2 years ago by mkoeppe

  • Branch set to u/mkoeppe/build_bin_sage_pip_install__delegate_to_build_bin_sage_python23

comment:2 Changed 2 years ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to 373ee9a5042f021525dd0f4d4009f2d090c00589
  • Status changed from new to needs_review

New commits:

​373ee9asage-pip-install: Use PYTHON=sage-python23

comment:3 Changed 2 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Looks good to me.

comment:4 Changed 2 years ago by mkoeppe

Thanks!

comment:5 Changed 2 years ago by vbraun

  • Branch changed from u/mkoeppe/build_bin_sage_pip_install__delegate_to_build_bin_sage_python23 to 373ee9a5042f021525dd0f4d4009f2d090c00589
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.