Opened 3 years ago

Closed 7 weeks ago

#29360 closed defect (fixed)

change_ring() should preserve sparsity of vectors and vector spaces

Reported by: Markus Wageringel Owned by:
Priority: major Milestone: sage-9.8
Component: linear algebra Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 5c13b55 (Commits, GitHub, GitLab) Commit: 5c13b55294b0afdfe3fa24f17d11c0735e1d5405
Dependencies: Stopgaps:

Status badges

Description

sage: vector(QQ, 10, {0:1}, sparse=True).change_ring(AA).is_sparse()  # should be True
False
sage: VectorSpace(QQ, 10, sparse=True).change_ring(RR).is_sparse()  # should be True
False

The analogous methods for matrices work correctly.

Change History (12)

comment:1 Changed 3 years ago by Matthias Köppe

Milestone: sage-9.1sage-9.2

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

comment:2 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.2sage-9.3

comment:3 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.3sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:4 Changed 19 months ago by Matthias Köppe

Milestone: sage-9.4sage-9.5

comment:5 Changed 14 months ago by Matthias Köppe

Milestone: sage-9.5sage-9.6

comment:6 Changed 10 months ago by Matthias Köppe

Milestone: sage-9.6sage-9.7

comment:7 Changed 5 months ago by Matthias Köppe

Milestone: sage-9.7sage-9.8

comment:8 Changed 2 months ago by Frédéric Chapoton

Authors: Frédéric Chapoton
Branch: u/chapoton/29360
Commit: f4f2cd31a3fc118ac7b6278dac8b8bb8acb09d02
Status: newneeds_review

New commits:

f4f2cd3preserve sparsity through change_ring

comment:9 Changed 2 months ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw

Green bot => positive review.

comment:10 Changed 2 months ago by git

Commit: f4f2cd31a3fc118ac7b6278dac8b8bb8acb09d025c13b55294b0afdfe3fa24f17d11c0735e1d5405

Branch pushed to git repo; I updated commit sha1. New commits:

5c13b55fix

comment:11 Changed 2 months ago by Frédéric Chapoton

Status: needs_reviewpositive_review

ok, setting to positive after having fixed the code

comment:12 Changed 7 weeks ago by Volker Braun

Branch: u/chapoton/293605c13b55294b0afdfe3fa24f17d11c0735e1d5405
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.