Opened 3 years ago

Closed 3 years ago

#29357 closed enhancement (fixed)

Add dependencies that should trigger reconfiguring

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.1
Component: build: configure Keywords:
Cc: embray, dimpase, jhpalmieri, mjo Merged in:
Authors: Erik Bray, Matthias Koeppe Reviewers: Michael Orlitzky
Report Upstream: N/A Work issues:
Branch: a01df9e (Commits, GitHub, GitLab) Commit: a01df9ecbace9506fa8ab707fd41c177ca5e1b93
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

Re-configure if src/bin/sage-env-config.in changes (from #29032) or build/bin/sage-build-env-config.in or build/pkgs/sage_conf/src/*.in change.

Change History (15)

comment:1 Changed 3 years ago by mkoeppe

Branch: → u/mkoeppe/add_dependencies_that_should_trigger_reconfiguring

comment:2 Changed 3 years ago by mkoeppe

Authors: → Erik Bray, Matthias Koeppe
Cc: dimpase jhpalmieri added
Commit: → f1b342439c459a244c3427013f75d4e1216777ec
Description: modified (diff)
Status: new → needs_review

New commits:

​80b3933Re-configure if src/bin/sage-env-config.in changes
​f1b3424Also reconfigure if build/bin/sage-build-env-config.in or build/pkgs/sage_conf/src/*.in change

comment:3 Changed 3 years ago by git

Commit: f1b342439c459a244c3427013f75d4e1216777ec → fe6aa38b09705c60f6000081eea6b67c4c6e0743

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​f5f493fRe-configure if src/bin/sage-env-config.in changes
​fe6aa38Also reconfigure if build/bin/sage-build-env-config.in or build/pkgs/sage_conf/src/*.in change

comment:4 Changed 3 years ago by mkoeppe

Cc: mjo added

comment:5 Changed 3 years ago by mjo

Would it save future-us a bit of time if we just included all *.in files in the list of things that trigger a re-configure? 

IN_FILES=$(shell find . -name .git -prune -o -type f -name '*.in' -print)
build/make/Makefile: ... $(IN_FILES)

comment:6 Changed 3 years ago by mjo

Testing that on an unclean tree shows that we need to exclude the ./local directory, too: 

$ find . -name .git -o -path ./local -prune -o -type f -name '*.in' -print
./build/make/Makefile-auto.in
./build/make/Makefile.in
./build/pkgs/pkgconf/patches/pkg-config.in
./build/pkgs/bzip2/patches/autotools/bzip2.pc.in
./build/pkgs/sage_conf/src/sage_conf.py.in
./build/pkgs/sage_conf/src/setup.cfg.in
./src/Makefile.in
./src/bin/sage-env-config.in
./src/MANIFEST.in

comment:7 Changed 3 years ago by mkoeppe

Running find in build should be enough. But we just added lots of .in files that are NOT processed by configure (as of yet!)

comment:8 Changed 3 years ago by mkoeppe

I would be in favor of an explicit list here...

comment:9 Changed 3 years ago by mjo

Argh, I didn't realize that some .in files aren't processed by ./configure. I would be in favor of an explicit list too, in that case. Can we copy/paste the AC_CONFIG_FILES from configure.ac, which is an explicit list?

comment:10 in reply to:  9 Changed 3 years ago by mkoeppe

Replying to mjo:

Can we copy/paste the AC_CONFIG_FILES from configure.ac, which is an explicit list?

Yes, that's the correct list of files.

comment:11 Changed 3 years ago by git

Commit: fe6aa38b09705c60f6000081eea6b67c4c6e0743 → a01df9ecbace9506fa8ab707fd41c177ca5e1b93

Branch pushed to git repo; I updated commit sha1. New commits:

​a01df9eRewrite build/make/Makefile dependencies using list of AC_CONFIG_FILES

comment:12 Changed 3 years ago by mkoeppe

Ready for review

comment:13 Changed 3 years ago by mjo

Reviewers: → Michael Orlitzky
Status: needs_review → positive_review

comment:14 Changed 3 years ago by mkoeppe

Thanks!

comment:15 Changed 3 years ago by vbraun

Branch: u/mkoeppe/add_dependencies_that_should_trigger_reconfiguring → a01df9ecbace9506fa8ab707fd41c177ca5e1b93
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.