Opened 20 months ago

Closed 18 months ago

Last modified 18 months ago

#29348 closed defect (fixed)

Remove dependency on 'twisted' for some unpickling in cartan_type

Reported by: jhpalmieri Owned by:
Priority: minor Milestone: sage-9.1
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: John Palmieri Reviewers: Travis Scrimshaw, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 67d2d5d (Commits, GitHub, GitLab) Commit: 67d2d5dab03bfa7ce47732a71521711f2fbebe80
Dependencies: #29320 Stopgaps:

Status badges

Description

A function in combinat/root_systems/cartan_type.py uses Python's twisted package to do some unpickling. In #29320, we are making twisted optional, so we should remove its use from this file.

Change History (10)

comment:1 Changed 20 months ago by jhpalmieri

  • Dependencies set to #29320

We can do this two ways: with #29320 as a dependency of this (my preference, since #29320 already has a positive review) or the other way around.

comment:2 Changed 20 months ago by jhpalmieri

  • Branch set to u/jhpalmieri/pickling-cartan-type-without-twisted

comment:3 Changed 20 months ago by git

  • Commit set to 67d2d5dab03bfa7ce47732a71521711f2fbebe80

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

67d2d5dtrac 29348: Remove dependency on 'twisted' of some unpickling in cartan_type.

comment:4 Changed 20 months ago by jhpalmieri

  • Authors set to John Palmieri
  • Status changed from new to needs_review

comment:5 Changed 18 months ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-9.2

Moving tickets to milestone sage-9.2 based on a review of last modification date, branch status, and severity.

comment:6 Changed 18 months ago by chapoton

  • Cc tscrim added

Looks good to me. Travis, your opinion ?

comment:7 Changed 18 months ago by tscrim

All it is is chnaging a test, not even the function itself. So no objections whatsoever.

comment:8 Changed 18 months ago by chapoton

  • Reviewers set to Travis Scrimshaw, Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, good

comment:9 Changed 18 months ago by vbraun

  • Branch changed from u/jhpalmieri/pickling-cartan-type-without-twisted to 67d2d5dab03bfa7ce47732a71521711f2fbebe80
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 Changed 18 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.1
Note: See TracTickets for help on using tickets.