Opened 3 years ago

Closed 3 years ago

#29344 closed enhancement (fixed)

configure.ac: fix bashisms

Reported by: Michael Orlitzky Owned by:
Priority: major Milestone: sage-9.1
Component: build: configure Keywords:
Cc: Dima Pasechnik, Matthias Köppe, Erik Bray Merged in:
Authors: Michael Orlitzky Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 7fbde82 (Commits, GitHub, GitLab) Commit: 7fbde82c9793ba624b94a8cefa939e999fad3b2e
Dependencies: Stopgaps:

Status badges

Description

Autoconf scripts are supposed to be POSIX sh -- not bash -- even though ours forces itself to be run with bash at the moment (chicken and egg problem). There are a few bashisms that are easy to fix:

  • Two double-equals comparisons in m4/ax_check_root.m4 and build/pkgs/gcc/spkg-configure.m4.
  • The construction of SAGE_SCRIPTS which, it turns out, is just a static list of files anyway and shouldn't be constructed dynamically.

Change History (10)

comment:1 Changed 3 years ago by Michael Orlitzky

Authors: Michael Orlitzky
Branch: u/mjo/ticket/29344
Commit: d78f97b7b4abb6b8f75e0d261037e861d96c5af3
Status: newneeds_review

New commits:

b46b740Trac #29344: fix bashism in m4/ax_check_root.m4.
7fbde82Trac #29344: fix bashism in build/pkgs/gcc/spkg-configure.m4.
33dcd38Trac #29344: build/make/Makefile.in: use a static list for SCRIPTS.
d78f97bTrac #29344: remove three unnecessary SCRIPTS dependencies.

comment:2 Changed 3 years ago by Michael Orlitzky

Cc: Dima Pasechnik Matthias Köppe Erik Bray added

comment:3 Changed 3 years ago by Matthias Köppe

See also #21559 -- which changes how the scripts are installed...

comment:4 Changed 3 years ago by git

Commit: d78f97b7b4abb6b8f75e0d261037e861d96c5af37fbde82c9793ba624b94a8cefa939e999fad3b2e

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

comment:5 Changed 3 years ago by Michael Orlitzky

Thanks, I dropped the two commits that touch SCRIPTS, since #21559 will take care of that.

comment:6 Changed 3 years ago by Matthias Köppe

Reviewers: Matthias Koeppe

I'll take a look

comment:7 Changed 3 years ago by Matthias Köppe

I'm running some tests on this (with a number of other tickets) at https://github.com/mkoeppe/sage/actions/runs/56355410, and will finish the review by tomorrow.

comment:8 Changed 3 years ago by Matthias Köppe

Status: needs_reviewpositive_review

comment:9 Changed 3 years ago by Dima Pasechnik

perhaps one can try building with zsh being the default shell. (I heard zsh is going to replace bash on MacOS)

comment:10 Changed 3 years ago by Volker Braun

Branch: u/mjo/ticket/293447fbde82c9793ba624b94a8cefa939e999fad3b2e
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.