Opened 11 months ago

Closed 10 months ago

#29342 closed defect (fixed)

pari spkg-configure.m4 should check gphelp more carefully

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.1
Component: build: configure Keywords:
Cc: dimpase, embray, fbissey, isuruf, gh-timokau, arojas, vdelecroix Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: cdd737e (Commits) Commit: cdd737e123539f06312fe1efc690555fb8d9e118
Dependencies: #29319 Stopgaps:

Description (last modified by mkoeppe)

Follow-up from #29319 for fedora-31-standard (​https://github.com/mkoeppe/sage/runs/509417970) and likewise on fedora-32-standard: 

Installing cypari-2.1.1
    Generating PARI functions: (!_) (#_) (%) (%#) (+_) (-_) CatalanCould not find translation file, docdir='/usr/bin' at /usr/bin/gphelp line 153.
    subprocess.CalledProcessError: Command '['gphelp', '-raw', 'Catalan']' returned non-zero exit status 2.

The branch is on top of #29319.

Change History (19)

comment:1 Changed 11 months ago by mkoeppe

  • Description modified (diff)

comment:2 Changed 11 months ago by fbissey

We have to be careful. My memory tells me cypari and gphelp -raw needs the documentation installed including the raw tex files - uncompressed. In the case of Catalan a run with strace tells me gphelp opens usersch3.tex.

comment:3 Changed 11 months ago by mkoeppe

Looks like this error was already discussed in #28242.

comment:4 Changed 11 months ago by mkoeppe

  • Cc vdelecroix added

comment:5 Changed 11 months ago by mkoeppe

The problem on Fedora is that the docs are not installed by default: 

# grep tsflags /etc/dnf/dnf.conf 
tsflags=nodocs

comment:6 Changed 11 months ago by mkoeppe

One needs to install using yum install pari-gp --setopt='tsflags='

comment:7 Changed 11 months ago by mkoeppe

  • Branch set to u/mkoeppe/pari_spkg_configure_m4_should_check_gphelp_more_carefully

comment:8 Changed 11 months ago by git

  • Commit set to d83e65703315981469da4080b472e9c6179f823e

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​08dc02dpari spkf-configure.m4: Check for gphelp
​64a028dbuild/pkgs/pari/distros/debian.txt: Add pari-doc
​d83e657build/pkgs/pari/distros/fedora.txt: Install the pari-gp documentation

comment:9 Changed 11 months ago by mkoeppe

  • Description modified (diff)

comment:10 Changed 11 months ago by git

  • Commit changed from d83e65703315981469da4080b472e9c6179f823e to cdd737e123539f06312fe1efc690555fb8d9e118

Branch pushed to git repo; I updated commit sha1. New commits:

​cdd737ebuild/pkgs/pari/spkg-configure.m4: Check gphelp

comment:11 Changed 11 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Status changed from new to needs_review

comment:12 Changed 10 months ago by mkoeppe

@dimpase: This one also touches fedora - and is ready for review

comment:13 Changed 10 months ago by dimpase

it should be 

+'pari-gp --setopt=tsflags='

not just 

+pari-gp --setopt=tsflags=

to prevent bootstrap for pulling these two things apart.

comment:14 Changed 10 months ago by mkoeppe

That flag applies to the whole command line.

comment:15 follow-up: Changed 10 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

OK, this works, positive review.

The next obstacle on Fedora 31: there is no openblas.pc, and so I cooked up one, put it somewhere, pointed PKG_CONFIG_PATH there, then openblas is recognised along with R, gsl, etc, but make ends with 

make[2]: Entering directory '/home/dima/sagetrac-mirror/build/make'
make[2]: *** No rule to make target '/home/dima/sagetrac-mirror/src/lib/pkgconfig/cblas.pc', needed by '/home/dima/sagetrac-mirror/local/lib/pkgconfig/cblas.pc'.  Stop.
make[2]: Leaving directory '/home/dima/sagetrac-mirror/build/make'

comment:16 Changed 10 months ago by mkoeppe

Thanks!

comment:17 in reply to: ↑ 15 Changed 10 months ago by mkoeppe

Replying to dimpase:

The next obstacle on Fedora 31: there is no openblas.pc, and so I cooked up one, put it somewhere, pointed PKG_CONFIG_PATH there, then openblas is recognised along with R, gsl, etc, but make ends with 

make[2]: Entering directory '/home/dima/sagetrac-mirror/build/make'
make[2]: *** No rule to make target '/home/dima/sagetrac-mirror/src/lib/pkgconfig/cblas.pc', needed by '/home/dima/sagetrac-mirror/local/lib/pkgconfig/cblas.pc'.  Stop.
make[2]: Leaving directory '/home/dima/sagetrac-mirror/build/make'

Yes, the pkgconfig mess needs to be cleaned up. #29082

comment:18 Changed 10 months ago by dimpase

Yes, I'm on it.

comment:19 Changed 10 months ago by vbraun

  • Branch changed from u/mkoeppe/pari_spkg_configure_m4_should_check_gphelp_more_carefully to cdd737e123539f06312fe1efc690555fb8d9e118
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.