Opened 2 years ago

Last modified 4 months ago

#29336 needs_work enhancement

Algorithm run time and implementation

Reported by: gh-surajkrmodi Owned by:
Priority: major Milestone: sage-9.7
Component: graph theory Keywords: Diameter
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: u/gh-surajkrmodi/algorithm_run_time_and_implementation (Commits, GitHub, GitLab) Commit: df8b76fad50b286f4363a429d06ad6adf56a20df
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-surajkrmodi)

I have included an experimental package for sagemath and package of graph diameter has been successfully installed

Change History (24)

comment:1 Changed 2 years ago by gh-surajkrmodi

  • Component changed from PLEASE CHANGE to graph theory
  • Description modified (diff)
  • Keywords Diameter added
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 2 years ago by gh-surajkrmodi

  • Branch set to u/gh-surajkrmodi/algorithm_run_time_and_implementation

comment:3 Changed 2 years ago by dcoudert

  • Commit set to b607344b9ab51a5f743f6c695e6ba4be61a3c18d
  • Status changed from needs_review to needs_work

This is not the right direction. If I understand well, you have copy/paste the code of Yuki Kawata, and do various edits in different files.

I you want to use the code of Yuki Kawata, you can propose an interface to this code and make it an optional package of Sagemath (at first an experimental package). See the developper manual.

New commits:

​b607344First commit

comment:4 Changed 2 years ago by git

  • Commit changed from b607344b9ab51a5f743f6c695e6ba4be61a3c18d to f5d36fde2ac5ac0583af3a9b8bd79e1fc833a58a

Branch pushed to git repo; I updated commit sha1. New commits:

​f5d36fd On branch t/29336/algorithm_run_time_and_implementation

comment:5 Changed 2 years ago by git

  • Commit changed from f5d36fde2ac5ac0583af3a9b8bd79e1fc833a58a to 533c7a41be00c48e3ce605a68ff64a3076ead668

Branch pushed to git repo; I updated commit sha1. New commits:

​533c7a4 deleted: sample/lol.tsv

comment:6 Changed 2 years ago by git

  • Commit changed from 533c7a41be00c48e3ce605a68ff64a3076ead668 to 8306b28b4cec72ef3f69342d10e914e1a5740c0d

Branch pushed to git repo; I updated commit sha1. New commits:

​8306b28 deleted: myscript.py

comment:7 Changed 2 years ago by git

  • Commit changed from 8306b28b4cec72ef3f69342d10e914e1a5740c0d to 29d11ec78631597d99ba65b205100654def92ad4

Branch pushed to git repo; I updated commit sha1. New commits:

​29d11ec modified: src/sage/graphs/bipartite_graph.py

comment:8 Changed 2 years ago by git

  • Commit changed from 29d11ec78631597d99ba65b205100654def92ad4 to 391d37acf43c3ec13c1f3dcc39434d40a2118058

Branch pushed to git repo; I updated commit sha1. New commits:

​391d37a new file: build/pkgs/graphdiameter/SPKG.txt

comment:9 Changed 2 years ago by gh-surajkrmodi

  • Description modified (diff)
  • Status changed from needs_work to needs_review

comment:10 Changed 2 years ago by gh-surajkrmodi

error i got while running sage --package sage-run received unknown option: --package usage: sage [options] Try 'sage -h' for more information.

comment:11 Changed 2 years ago by git

  • Commit changed from 391d37acf43c3ec13c1f3dcc39434d40a2118058 to 68139bcd5da3c331428cad87d00c4d42e163328c

Branch pushed to git repo; I updated commit sha1. New commits:

​68139bc modified: build/pkgs/graphdiameter/checksums.ini

comment:12 Changed 2 years ago by git

  • Commit changed from 68139bcd5da3c331428cad87d00c4d42e163328c to 7d22f2700d9711a22c540b872af2b90e82207045

Branch pushed to git repo; I updated commit sha1. New commits:

​7d22f27 modified: build/pkgs/graphdiameter/spkg-install

comment:13 Changed 2 years ago by gh-surajkrmodi

  • Description modified (diff)

waiting for review and further instructions

comment:14 Changed 2 years ago by git

  • Commit changed from 7d22f2700d9711a22c540b872af2b90e82207045 to df8b76fad50b286f4363a429d06ad6adf56a20df

Branch pushed to git repo; I updated commit sha1. New commits:

​df8b76f modified: build/pkgs/graphdiameter/SPKG.txt

comment:15 Changed 2 years ago by dcoudert

I don't have the expertise to check if this is the right way to make an experimental package. I will call for help. Meanwhile, where can I find the tarball ?

comment:16 Changed 2 years ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-9.2

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

comment:17 Changed 2 years ago by slabbe

  • Status changed from needs_review to needs_work

Information how to make a new package is here: ​https://doc.sagemath.org/html/en/developer/packaging.html

Note that a new feature is to provide the upstream_url directly in the checksums file, see for instance #30342.

Because the upstream url is not provided, I change the status to needs work.

comment:18 Changed 2 years ago by slabbe

Also it seems the branch is doing a chmod change to the file src/sage/graphs/centrality.pyx which is weird.

comment:19 Changed 2 years ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:20 Changed 18 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:21 Changed 14 months ago by dcoudert

May be it's time to move this ticket to wontfix.

comment:22 Changed 13 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5

Setting a new milestone for this ticket based on a cursory review.

comment:23 Changed 8 months ago by mkoeppe

  • Milestone changed from sage-9.5 to sage-9.6

comment:24 Changed 4 months ago by mkoeppe

  • Milestone changed from sage-9.6 to sage-9.7
Note: See TracTickets for help on using tickets.