Opened 21 months ago

Last modified 20 months ago

#29326 closed enhancement

Improvements for projection into affine hull — at Version 1

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.1
Component: geometry Keywords: polyhedra, affine hull
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers:
Report Upstream: N/A Work issues:
Branch: public/29326 (Commits, GitHub, GitLab) Commit: 6d12f79f482bf942d4602e7d8cb0bae896b0c7c4
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-kliem)

This ticket renames affine_hull of Polyhedron_base to affine_hull_projection and adds a deprecation warning.

Before, this function was hard to recognize, as by the name one expected to obtain the affine hull and not the polyhedron projected into it.

Also this ticket makes use of #28724 to simplify construction: We determine a transformation matrix A and a vector b and basically return A*P - b, where P is the polyhedron.

Change History (1)

comment:1 Changed 21 months ago by gh-kliem

  • Branch set to public/29326
  • Commit set to 6d12f79f482bf942d4602e7d8cb0bae896b0c7c4
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

f9e1283simplified projection into affine_hull
6d12f79rename `affine_hull` to `affine_hull_projection`
Note: See TracTickets for help on using tickets.