Opened 20 months ago

Last modified 3 months ago

#29322 new defect

Fix or disable failing package testsuites (spkg-check)

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.5
Component: build Keywords:
Cc: dimpase, jhpalmieri Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jhpalmieri)

There are many spkgs whose testsuites fail.

sage-spkg uses the following defaults:

# Since Python's self-tests seem to fail on all platforms, we disable
# its test suite by default.
if [ -z "$SAGE_CHECK_PACKAGES" ]; then
    SAGE_CHECK_PACKAGES='!python2,!python3'
fi

More should be added to adjust for expected failures.

  • pathpy -- spkg-check picks up top-level tox.ini and gets confused

See also:

  • #29301 - sage-spkg: Add an option -w for warning only if spkg-check fails
  • #22866 - Cygwin spkg-check meta-ticket
  • #28998 - Add script-type _spkg_check package that installs tox, mock, pytest etc.
  • #29087 - Add GitHub Actions workflow ...

has comments in tox.ini on skipping some testsuites

  • #30093 - skip test suite for curl, git

Change History (15)

comment:1 Changed 20 months ago by mkoeppe

  • Description modified (diff)

comment:2 Changed 20 months ago by mkoeppe

  • Description modified (diff)

comment:3 Changed 20 months ago by mkoeppe

  • Description modified (diff)
  • Summary changed from Fix or disable failing package testsuites to Fix or disable failing package testsuites (spkg-check)

comment:5 Changed 20 months ago by mkoeppe

  • Description modified (diff)

comment:6 Changed 20 months ago by mkoeppe

  • Description modified (diff)

comment:7 Changed 18 months ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-9.2

comment:8 Changed 16 months ago by mkoeppe

Let's update the default list of SAGE_CHECK_PACKAGES -- and perhaps also invent another syntax in addition to '!SPKG', perhaps '?SPKG', to indicate that this package should only be run like SAGE_CHECK=warn.

comment:9 Changed 16 months ago by mkoeppe

Also there are some additional packages for which it just does not make any sense to run the testsuite: curl, git, ...

comment:10 follow-up: Changed 16 months ago by jhpalmieri

Well, we can just disable those test suites permanently, by making their spkg-check.in a no-op. (I would prefer this to deleting spkg-check.in, in case some enterprising developer later decides to add one.)

comment:11 in reply to: ↑ 10 Changed 16 months ago by mkoeppe

Replying to jhpalmieri:

Well, we can just disable those test suites permanently, by making their spkg-check.in a no-op. (I would prefer this to deleting spkg-check.in, in case some enterprising developer later decides to add one.)

That (+ a comment why it is disabled) sounds good.

comment:12 Changed 16 months ago by jhpalmieri

  • Description modified (diff)

See #30093.

comment:13 Changed 12 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:14 Changed 7 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Moving this ticket to 9.4, as it seems unlikely that it will be merged in 9.3, which is in the release candidate stage

comment:15 Changed 3 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5
Note: See TracTickets for help on using tickets.