Opened 3 years ago

Closed 3 years ago

#29312 closed defect (fixed)

Fix attribute lookup in _coerce_map_from_base_ring() for Cython classes

Reported by: Peter Bruin Owned by:
Priority: minor Milestone: sage-9.1
Component: coercion Keywords:
Cc: Markus Wageringel, Travis Scrimshaw Merged in:
Authors: Peter Bruin Reviewers: Markus Wageringel
Report Upstream: N/A Work issues:
Branch: c4631b6 (Commits, GitHub, GitLab) Commit: c4631b6b2ff70da6dc329785a521c9a29dc1eade
Dependencies: Stopgaps:

Status badges

Description

Reported by Markus Wageringel in comment:14:ticket:29247:

sage: F.<x,y,z> = FreeAlgebra(QQ, implementation='letterplace')
sage: F._coerce_map_from_base_ring()
...
AttributeError: type object 'sage.algebras.letterplace.free_algebra_letterplace' has no attribute 'from_base_ring'

Change History (3)

comment:1 Changed 3 years ago by Peter Bruin

Branch: u/pbruin/29312-from_base_ring
Commit: c4631b6b2ff70da6dc329785a521c9a29dc1eade
Status: newneeds_review

comment:2 Changed 3 years ago by Markus Wageringel

Reviewers: Markus Wageringel
Status: needs_reviewpositive_review

This looks good to me. Thanks.

comment:3 Changed 3 years ago by Volker Braun

Branch: u/pbruin/29312-from_base_ringc4631b6b2ff70da6dc329785a521c9a29dc1eade
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.