Opened 3 years ago

Closed 3 years ago

#29311 closed defect (fixed)

Initialise the unit element in new_CRing

Reported by: pbruin Owned by:
Priority: major Milestone: sage-9.1
Component: coercion Keywords:
Cc: gh-mwageringel, tscrim Merged in:
Authors: Peter Bruin Reviewers: Travis Scrimshaw, Markus Wageringel
Report Upstream: N/A Work issues:
Branch: 799cf55 (Commits, GitHub, GitLab) Commit: 799cf557a72c3450efe24980a157579b309b6e72
Dependencies: Stopgaps:

Status badges


Reported by Markus Wageringel in comment:14:ticket:29247:

sage: R.<x,y,z> = QQ[]
sage: from sage.libs.singular.function_factory import ff
sage: W = ff.ring(ff.ringlist(R), ring=R)
sage: C = sage.rings.polynomial.plural.new_CRing(W, R.base_ring())
sage:   # should be 1

Change History (4)

comment:1 Changed 3 years ago by pbruin

Branch: u/pbruin/29311-new_CRing
Commit: cd3524d7fa10fadd75e73b1e27b4fab88e996432
Status: newneeds_review

comment:2 Changed 3 years ago by git

Commit: cd3524d7fa10fadd75e73b1e27b4fab88e996432799cf557a72c3450efe24980a157579b309b6e72

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

799cf55Trac 29311: initialise the unit element in new_CRing

comment:3 Changed 3 years ago by gh-mwageringel

Reviewers: Travis Scrimshaw, Markus Wageringel
Status: needs_reviewpositive_review

Thank you for fixing this so quickly. I can confirm that this also resolves the problem that came up in #25993.

I will add Travis to the reviewers, as he was positive about this approach.

comment:4 Changed 3 years ago by vbraun

Branch: u/pbruin/29311-new_CRing799cf557a72c3450efe24980a157579b309b6e72
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.