#29305 closed defect (fixed)

Repair cython_aliases ARB_LIBRARY

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.1
Component: build Keywords:
Cc: dimpase, mmezzarobba Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: dcd755a (Commits, GitHub, GitLab) Commit: dcd755a741a2edc46683cfedb67de54cffec880f
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

It was moved from sage-env-config to sage-build-env-config. However it is used in cython_aliases, as reported in https://groups.google.com/d/msg/sage-devel/lMDRg3OJtl4/zU-AQNZwAQAJ, which user packages may be using.

Change History (12)

comment:1 follow-up: Changed 19 months ago by mkoeppe

But actually I think a better solution than cython_aliases needs to be found in the longer term. Installed .pxd headers should be made usable without a special environment.

comment:2 in reply to: ↑ 1 Changed 19 months ago by mjo

Replying to mkoeppe:

But actually I think a better solution than cython_aliases needs to be found in the longer term. Installed .pxd headers should be made usable without a special environment.

Yeah, most of what cython_aliases does is run pkg-config for you. I think the standard cython build tools allow you to do that manually if you want, but what's missing is a way to easily get e.g. all of the flags that sage itself used. Probably sagelib needs a *.pc file at some point, and you could just gets the libs/include-dirs from that.

comment:3 Changed 19 months ago by mkoeppe

  • Description modified (diff)
  • Summary changed from Move ARB_LIBRARY back from sage-build-env-config to sage-env-config to Repair cython_aliases ARB_LIBRARY

comment:4 Changed 19 months ago by mkoeppe

  • Branch set to u/mkoeppe/move_arb_library_back_from_sage_build_env_config_to_sage_env_config

comment:5 Changed 19 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to be3c581869e78a31f51d44511461f06d5aafe1d8
  • Status changed from new to needs_review

New commits:

be3c581Configure ARB_LIBRARY through sage_conf

comment:6 Changed 19 months ago by dimpase

funny spacing:

+var('ARB_LIBRARY',                   'arb')

comment:7 Changed 19 months ago by mkoeppe

It aligns with lines above

comment:8 Changed 19 months ago by dimpase

align at least the line directly above it too, then.

comment:9 Changed 19 months ago by git

  • Commit changed from be3c581869e78a31f51d44511461f06d5aafe1d8 to dcd755a741a2edc46683cfedb67de54cffec880f

Branch pushed to git repo; I updated commit sha1. New commits:

dcd755acosmetic change

comment:10 Changed 19 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

OK

comment:11 Changed 19 months ago by mkoeppe

Thanks!

comment:12 Changed 19 months ago by vbraun

  • Branch changed from u/mkoeppe/move_arb_library_back_from_sage_build_env_config_to_sage_env_config to dcd755a741a2edc46683cfedb67de54cffec880f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.