Opened 3 years ago

Closed 3 years ago

#29292 closed defect (fixed)

Fix identifier clash in configure

Reported by: Matthias Köppe Owned by:
Priority: critical Milestone: sage-9.1
Component: build: configure Keywords:
Cc: Dima Pasechnik, John Palmieri, Volker Braun Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 77d2da5 (Commits, GitHub, GitLab) Commit: 77d2da5d8ff8fd4ed7d55ffb5d62d36011441756
Dependencies: Stopgaps:

Status badges

Description

An interaction between #28788 and #28095 has slightly broken configure: The shell variables SPKG_NAME and SPKG_TYPE are m4-substituted by some previous values. The generated configure file still works fine but looks strange.

Change History (7)

comment:1 Changed 3 years ago by Matthias Köppe

Branch: u/mkoeppe/fix_identifier_clash_in_configure

comment:2 Changed 3 years ago by Matthias Köppe

Authors: Matthias Koeppe
Cc: Volker Braun added
Commit: 0e5124a41d2c7f9b646d77836ce611f3962ec5a0
Status: newneeds_review

New commits:

0e5124aFix identifier clash in configure

comment:3 Changed 3 years ago by git

Commit: 0e5124a41d2c7f9b646d77836ce611f3962ec5a077d2da5d8ff8fd4ed7d55ffb5d62d36011441756

Branch pushed to git repo; I updated commit sha1. New commits:

77d2da5Merge tag '9.1.beta7' into t/29292/fix_identifier_clash_in_configure

comment:4 Changed 3 years ago by Matthias Köppe

Anyone interested in reviewing this simple fix?

comment:5 Changed 3 years ago by Dima Pasechnik

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

lgtm

comment:6 Changed 3 years ago by Matthias Köppe

Thank you!

comment:7 Changed 3 years ago by Volker Braun

Branch: u/mkoeppe/fix_identifier_clash_in_configure77d2da5d8ff8fd4ed7d55ffb5d62d36011441756
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.