Opened 2 years ago
Closed 11 months ago
#29291 closed enhancement (fixed)
Check for required extension module "ssl" in python3 build and spkgconfigure
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sage9.5 
Component:  build  Keywords:  
Cc:  dimpase, embray, jhpalmieri, slelievre, dunfield, tmonteil  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  John Palmieri 
Report Upstream:  N/A  Work issues:  
Branch:  789c960 (Commits, GitHub, GitLab)  Commit:  789c96048da38405920f4c4561171d2fbfeb66fc 
Dependencies:  Stopgaps: 
Description (last modified by )
Follow up from #27705.
As openssl has been a standard package since Sage 9.3, there is no more point in accepting system python3 without ssl support or ignoring errors in building the ssl module when building the python3 spkg.
As SSL issues are no longer a likely diagnosis for failures with launching the notebook, we change the corresponding code in src/bin/sagenotebook
. (Prompted by https://groups.google.com/g/sagedevel/c/IXypXTbVkDM/m/CsWl8HbZAwAJ)
Change History (18)
comment:1 Changed 2 years ago by
comment:2 Changed 2 years ago by
 Milestone changed from sage9.1 to sage9.2
pushing these forward to 9.2
comment:3 Changed 2 years ago by
 Milestone changed from sage9.2 to sage9.3
comment:4 Changed 17 months ago by
 Milestone changed from sage9.3 to sage9.4
Setting new milestone based on a cursory review of ticket status, priority, and last modification date.
comment:5 Changed 13 months ago by
 Milestone changed from sage9.4 to sage9.5
comment:6 Changed 12 months ago by
 Branch set to u/mkoeppe/check_for_more_strictly_required_extension_module__ssl__in_python_build
comment:7 Changed 12 months ago by
 Commit set to b6c27a7f97e596680162a2f7be5ef7bd09bc57fd
 Description modified (diff)
 Status changed from new to needs_review
 Summary changed from Check for more strictly required extension module "ssl" in Python build to Check for required extension module "ssl" in python3 build and spkgconfigure
New commits:
b6c27a7  build/pkgs/python3/{spkgconfigure.m4,spkgbuild.in}: Ensure ssl module is present

comment:8 Changed 12 months ago by
 Commit changed from b6c27a7f97e596680162a2f7be5ef7bd09bc57fd to fa75b3e01d98452604619be36463c9e40e6c7793
Branch pushed to git repo; I updated commit sha1. New commits:
fa75b3e  src/bin/sagenotebook: On failures to import notebook/jupyterlab modules, point to instructions; do not offer a guessed diagnosis

comment:9 Changed 12 months ago by
 Cc slelievre dunfield added
 Description modified (diff)
comment:10 Changed 12 months ago by
 Description modified (diff)
comment:11 followup: ↓ 13 Changed 12 months ago by
In build/pkgs/python3/spkgbuild.in
, line 32,
the (preexisting) typo explicitely > explicitly
could be fixed since we're editing that file.
Any suggestions on how to review this ticket?
comment:12 Changed 11 months ago by
 Cc tmonteil added
comment:13 in reply to: ↑ 11 Changed 11 months ago by
Replying to slelievre:
In
build/pkgs/python3/spkgbuild.in
, line 32, the (preexisting) typo explicitely > explicitly could be fixed since we're editing that file.Any suggestions on how to review this ticket?
I guess if we can't find systems without the Python module ssl already installed, maybe we should just merge it and move on?
comment:14 Changed 11 months ago by
Right, I'm not aware of a distribution whose python would be missing the ssl module. The new configuration tests here on the ticket protect against broken pythons compiled by users. The most likely scenario could be that a user configures the source from within the sage sh
of some old installation of Sage.
Probably not useful to replicate something like this in order to review the ticket.
comment:15 Changed 11 months ago by
Why not just remove PREREQUISITE_ERROR
completely?
comment:16 Changed 11 months ago by
 Commit changed from fa75b3e01d98452604619be36463c9e40e6c7793 to 789c96048da38405920f4c4561171d2fbfeb66fc
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
1fc8732  build/pkgs/python3/{spkgconfigure.m4,spkgbuild.in}: Ensure ssl module is present

42489c1  src/bin/sagenotebook: On failures to import notebook/jupyterlab modules, point to instructions; do not offer a guessed diagnosis

789c960  src/bin/sagenotebook: Remove PREREQUISITE_ERROR completely

comment:17 Changed 11 months ago by
 Reviewers set to John Palmieri
 Status changed from needs_review to positive_review
This works for me, but my Python isn't broken (nor do I want to build a broken one), so I can't test the error messages. The code all makes sense, though.
comment:18 Changed 11 months ago by
 Branch changed from u/mkoeppe/check_for_more_strictly_required_extension_module__ssl__in_python_build to 789c96048da38405920f4c4561171d2fbfeb66fc
 Resolution set to fixed
 Status changed from positive_review to closed
Can this also work with certifi package? I had issues previously with some other packages on Mac, and certifi seemed to fix it