#29288 closed defect (fixed)

MagmaGBLogPrettyPrinter v Python3

Reported by: malb Owned by:
Priority: major Milestone: sage-9.1
Component: interfaces: optional Keywords: magma
Cc: Merged in:
Authors: Martin Albrecht Reviewers: Kwankyu Lee
Report Upstream: N/A Work issues:
Branch: 170527f (Commits, GitHub, GitLab) Commit: 170527feab8ee32cfde6c14e5993305622366391
Dependencies: Stopgaps:

Status badges

Description (last modified by malb)

Make I.groebner_basis(algorithm="magma", prot="sage") work again.

Change History (8)

comment:1 Changed 19 months ago by malb

  • Branch set to u/malb/magmagblogprettyprinter_v_python3

comment:2 Changed 19 months ago by malb

  • Authors set to Martin Albrecht
  • Commit set to 111129ed75d6ecad9bc8c5617f02fce2321b7dc3
  • Component changed from PLEASE CHANGE to interfaces: optional
  • Description modified (diff)
  • Keywords magma added
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

New commits:

111129ebytes vs string in MagmaGBLogPrettyPrinter

comment:3 Changed 19 months ago by chapoton

Several failing doctests, see patchbots long reports.

I would guess that this is going to be subtle.

comment:4 Changed 19 months ago by git

  • Commit changed from 111129ed75d6ecad9bc8c5617f02fce2321b7dc3 to 14dfd894b06d68911e43388d4de01e1b9188b041

Branch pushed to git repo; I updated commit sha1. New commits:

14dfd89don't assume bytes but accept them

comment:5 Changed 19 months ago by malb

This should be fixed now (i.e. passes tests locally)

comment:6 Changed 19 months ago by git

  • Commit changed from 14dfd894b06d68911e43388d4de01e1b9188b041 to 170527feab8ee32cfde6c14e5993305622366391

Branch pushed to git repo; I updated commit sha1. New commits:

170527fbe more robust

comment:7 Changed 18 months ago by klee

  • Reviewers set to Kwankyu Lee
  • Status changed from needs_review to positive_review

It works, and LGTM.

comment:8 Changed 18 months ago by vbraun

  • Branch changed from u/malb/magmagblogprettyprinter_v_python3 to 170527feab8ee32cfde6c14e5993305622366391
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.