#29263 closed enhancement (fixed)

use richcmp in interfaces

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.1
Component: interfaces Keywords:
Cc: tscrim, gh-mwageringel Merged in:
Authors: Frédéric Chapoton Reviewers: Markus Wageringel , Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 0fbb59c (Commits, GitHub, GitLab) Commit: 0fbb59c853080f61d1f61b4050dd0c942dc3c7a4
Dependencies: Stopgaps:

Status badges

Description

another tentative step towards the end of _cmp_

Change History (6)

comment:1 Changed 16 months ago by chapoton

  • Branch set to u/chapoton/29263
  • Commit set to 0fbb59c853080f61d1f61b4050dd0c942dc3c7a4
  • Status changed from new to needs_review

New commits:

0fbb59cuse richcmp in interfaces

comment:2 Changed 16 months ago by chapoton

  • Cc tscrim gh-mwageringel added

could someone please review ? This involves optional packages and commercial software.

comment:3 Changed 16 months ago by gh-mwageringel

I can confirm that this passes the Mathematica tests, but I do not have access to Maple and have not been able to install Polymake. The changes look ok, though.

comment:4 Changed 16 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 16 months ago by tscrim

  • Reviewers changed from Travis Scrimshaw to Markus Wageringel , Travis Scrimshaw

comment:6 Changed 16 months ago by vbraun

  • Branch changed from u/chapoton/29263 to 0fbb59c853080f61d1f61b4050dd0c942dc3c7a4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.