#29260 closed enhancement (fixed)

remove some imports of six in .pyx files

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.1
Component: refactoring Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 3598130 (Commits, GitHub, GitLab) Commit: 359813032e0182986e39b5c0a9ed3abbc4b7af99
Dependencies: Stopgaps:

Status badges

Description

This was not good for speed.

Change History (6)

comment:1 Changed 16 months ago by chapoton

  • Branch set to u/chapoton/29260
  • Commit set to d32acb9dfaa732e149107e9bc298ff7da7a90ebc
  • Status changed from new to needs_review

New commits:

d32acb9remove some imports of six in cython files

comment:2 Changed 16 months ago by chapoton

green bot, please review

comment:3 Changed 16 months ago by tscrim

I don't see the point of the iter in this change:

-            data = six.iteritems(data)
+            data = iter(data.items())

It is an unnecessary iterator call in Python3, and in Python2, the list is already created. So I would have data = data.items().

comment:4 Changed 16 months ago by git

  • Commit changed from d32acb9dfaa732e149107e9bc298ff7da7a90ebc to 359813032e0182986e39b5c0a9ed3abbc4b7af99

Branch pushed to git repo; I updated commit sha1. New commits:

3598130trac 29260 do not need iter()

comment:5 Changed 16 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Thanks.

comment:6 Changed 16 months ago by vbraun

  • Branch changed from u/chapoton/29260 to 359813032e0182986e39b5c0a9ed3abbc4b7af99
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.