Opened 2 years ago

Closed 2 years ago

#29245 closed enhancement (fixed)

spkg-configure for fplll

Reported by: mjo Owned by:
Priority: major Milestone: sage-9.1
Component: build: configure Keywords:
Cc: embray, dimpase, mkoeppe, ​isuruf, fbissey Merged in:
Authors: Michael Orlitzky Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 7fc917b (Commits, GitHub, GitLab) Commit: 7fc917b6cdeac783ad8dd05aed19fd783772d53d
Dependencies: Stopgaps:

Status badges

Description (last modified by mjo)

fplll ships a pkg-config file, is slow to build, and has only one dependency that was already spkg-configurified.

It is packaged for a few distros, so let's use it.

Change History (14)

comment:1 Changed 2 years ago by mjo

  • Authors set to Michael Orlitzky
  • Branch set to u/mjo/ticket/29245
  • Cc embray dimpase mkoeppe ​isuruf fbissey added
  • Commit set to 34d1c62c3496c6c78238d8a350f7e58bcf127b7c
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​34d1c62Trac #29245: new spkg-configure.m4 for fplll.

comment:2 Changed 2 years ago by mkoeppe

Could you add build/pkgs/fplll/distros/ please (see #29129)?

comment:3 Changed 2 years ago by git

  • Commit changed from 34d1c62c3496c6c78238d8a350f7e58bcf127b7c to e478f113368a16d45c1c10f71d5dd49f47047724

Branch pushed to git repo; I updated commit sha1. New commits:

​e478f11Trac #29245: add "distros" directory with an entry for Gentoo.

comment:4 Changed 2 years ago by mjo

Sure. I'll add the others if people can tell me what to stick in the text files. For example I'm pretty sure you need both the main package and -dev on Debian, but who knows. I'm also pretty sure that someone is going to tell me the pc file is missing somewhere and make me do a header/library search...

comment:5 Changed 2 years ago by mkoeppe

​https://repology.org/ has the info you need

comment:6 Changed 2 years ago by mkoeppe

And this all can be tested using tox.

comment:7 Changed 2 years ago by dimpase

on debian one needs libfplll-dev and (probably) fplll-tools

  • the latter is very small, so it doesn't hurt to ask for it be installed.

comment:8 Changed 2 years ago by git

  • Commit changed from e478f113368a16d45c1c10f71d5dd49f47047724 to e8c386758094cb74e8c3c498a220dbccb0892a48

Branch pushed to git repo; I updated commit sha1. New commits:

​e8c3867Trac #29245: add Debian package information for fplll.

comment:9 Changed 2 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to needs_work

Debian fplll package is broken - fplll/pruner/ headers are missing. So one gets 

[fpylll-0.5.1dev]     building 'fpylll.fplll.integer_matrix' extension
[fpylll-0.5.1dev]     creating build/temp.linux-x86_64-2.7/build/src/fpylll/fplll
[fpylll-0.5.1dev]     gcc -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall -Wno-unused -fPIC -Isrc/fpylll/fplll -I/home/dimpase/sage/local/lib/python2.7/site-packages/cysignals -I/home/dimpase/sage/local/include -I/home/dimpase/sage/local/lib/python2.7/site-packages/numpy/core/include -I/home/dimpase/sage/local/include/python2.7 -c build/src/fpylll/fplll/integer_matrix.cpp -o build/temp.linux-x86_64-2.7/build/src/fpylll/fplll/integer_matrix.o -std=c++11
[fpylll-0.5.1dev]     build/src/fpylll/fplll/integer_matrix.cpp:698:10: fatal error: fplll/pruner/pruner.h: No such file or directory
[fpylll-0.5.1dev]      #include "fplll/pruner/pruner.h"
[fpylll-0.5.1dev]               ^~~~~~~~~~~~~~~~~~~~~~~
[fpylll-0.5.1dev]     compilation terminated.
[fpylll-0.5.1dev]     error: command 'gcc' failed with exit status 1

I propose to include a check for this header in the macro.

comment:10 follow-up: Changed 2 years ago by dimpase

In fact, fplll-5.2.1 does not have that header, they only appear in fplll-5.3

so, just updating the minimal version will do.

comment:11 Changed 2 years ago by git

  • Commit changed from e8c386758094cb74e8c3c498a220dbccb0892a48 to 7fc917b6cdeac783ad8dd05aed19fd783772d53d

Branch pushed to git repo; I updated commit sha1. New commits:

​7fc917bTrac #29245: increase minimum version of fplll to 5.3.

comment:12 in reply to: ↑ 10 Changed 2 years ago by mjo

Replying to dimpase:

In fact, fplll-5.2.1 does not have that header, they only appear in fplll-5.3

so, just updating the minimal version will do.

Thanks, fixed.

comment:13 Changed 2 years ago by dimpase

  • Status changed from needs_work to positive_review

comment:14 Changed 2 years ago by vbraun

  • Branch changed from u/mjo/ticket/29245 to 7fc917b6cdeac783ad8dd05aed19fd783772d53d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.