Opened 2 years ago

Closed 2 years ago

#29242 closed enhancement (fixed)

CombinatorialPolyhedron: `bit_repr_` -> `bit_rep_`

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.1
Component: geometry Keywords:
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Laith Rastanawi
Report Upstream: N/A Work issues:
Branch: 0f38cbe (Commits, GitHub, GitLab) Commit: 0f38cbeab73c31b3068340d32e0b41e965cbb105
Dependencies: #29190 Stopgaps:

Status badges

Description (last modified by gh-kliem)

This is a follow up on #28608.

It turns out we missed the case bit_repr_.

In order to be consistent, we change this to bit_rep_ (at the moment there are both versions in use).

Even though those 4 python functions in conversions.pyx are very unlikely to be used elsewhere, we add deprecation warnings according to the name those 4 functions had before #28608.

Change History (10)

comment:1 Changed 2 years ago by gh-kliem

  • Branch set to public/29242
  • Commit set to 2c255ab00ccf95759c4b631e3ef7cc94c84b4f32
  • Status changed from new to needs_review

New commits:

​328c16dcopy for ListOfFaces
​8beef7cadd polar for combinatorial polyhedron
​2c255ab_bit_repr_ -> _bit_rep_

comment:2 Changed 2 years ago by gh-kliem

The reason I missed it is simple: autoreplacement.

When changing back def _repr_(self) I mistakenly also changed bit_rep_ to _bit_repr_ again.

Last edited 2 years ago by gh-kliem (previous) (diff)

comment:3 Changed 2 years ago by gh-kliem

  • Description modified (diff)

comment:4 Changed 2 years ago by git

  • Commit changed from 2c255ab00ccf95759c4b631e3ef7cc94c84b4f32 to 1c7f1b296a896a3be5488c72c8364b027a288b27

Branch pushed to git repo; I updated commit sha1. New commits:

​1c7f1b2corrected ticket number

comment:5 Changed 2 years ago by gh-LaisRast

Once #29190 is done, I will put this on "positive review"

comment:6 Changed 2 years ago by gh-LaisRast

  • Reviewers set to Laith Rastanawi
  • Status changed from needs_review to positive_review

comment:7 Changed 2 years ago by gh-kliem

  • Status changed from positive_review to needs_work

Merge conflict.

comment:8 Changed 2 years ago by gh-kliem

  • Branch changed from public/29242 to public/29242-reb
  • Commit changed from 1c7f1b296a896a3be5488c72c8364b027a288b27 to 0f38cbeab73c31b3068340d32e0b41e965cbb105
  • Status changed from needs_work to needs_review

Sorry, had to rebase it to the current branch of #29190.

New commits:

​23b87edcopy for ListOfFaces
​309150badd polar for combinatorial polyhedron
​586bc82renamed polar to dual
​73cf39ffixing doctest
​de0238a_bit_repr_ -> _bit_rep_
​0f38cbecorrected ticket number

comment:9 Changed 2 years ago by gh-LaisRast

  • Status changed from needs_review to positive_review

comment:10 Changed 2 years ago by vbraun

  • Branch changed from public/29242-reb to 0f38cbeab73c31b3068340d32e0b41e965cbb105
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.