Opened 11 months ago
Closed 11 months ago
#29233 closed defect (fixed)
bootstrap && make distclean broken
Reported by: | vbraun | Owned by: | |
---|---|---|---|
Priority: | blocker | Milestone: | sage-9.1 |
Component: | build: configure | Keywords: | |
Cc: | dimpase, embray, jhpalmieri | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | 0dc97db (Commits) | Commit: | 0dc97dbb12fcde2981cc0a4ef4bbd4938b5e74dc |
Dependencies: | Stopgaps: |
Description (last modified by )
- #26964 now creates documentation files during bootstrap
- make distclean blows away these generated files
- subsequent make fails when building documentation
This ticket fixes it by deleting the generated files in bootstrap-clean
instead of misc-clean
.
Change History (14)
comment:1 Changed 11 months ago by
comment:2 Changed 11 months ago by
make distclean
should remove ./configure
comment:3 Changed 11 months ago by
Volker, are you sure you regenerated the configure tar ball?
comment:4 Changed 11 months ago by
Our distclean
doesn't remove ./configure
, neither should it ihmo. Distclean should remove whatever configure output there is, but it should keep the actual configure script which would go into a proper tarball.
comment:5 Changed 11 months ago by
well, then it's a bug that make distclean
removes stuff not made by make all
or by ./configure
comment:6 Changed 11 months ago by
Correct. And to fix it we can either kludge around with make distclean
to not delete what should be build artifacts, or move building the documentation from bootstrap
to make doc
.
comment:7 Changed 11 months ago by
it's not just documentation. One possible way to use these is to generate help info before the build, something like: "you're on Debian, to make use of as many
Debian external packages as possible do apt-get install ...
"
comment:8 Changed 11 months ago by
also, it's used for CI. You need to tell your CI host what to install to minimise build time, and this is OS-specific and pre-build.
comment:9 Changed 11 months ago by
OK, deletion should be done by bootstrap-clean
, not misc-clean
. My bad.
However, note that bootstrap is the correct build phase for making these files. This build phase, after all, prepares src
for sdist
, the distribution for dist and for configure.
comment:10 Changed 11 months ago by
- Branch set to u/mkoeppe/bootstrap____make_distclean_broken
comment:11 Changed 11 months ago by
- Commit set to 0dc97dbb12fcde2981cc0a4ef4bbd4938b5e74dc
- Status changed from new to needs_review
New commits:
0dc97db | Clean src/doc/en/installation/*.txt in bootstrap-clean, not misc-clean
|
comment:12 Changed 11 months ago by
- Description modified (diff)
comment:13 Changed 11 months ago by
- Reviewers set to Dima Pasechnik
- Status changed from needs_review to positive_review
lgtm
comment:14 Changed 11 months ago by
- Branch changed from u/mkoeppe/bootstrap____make_distclean_broken to 0dc97dbb12fcde2981cc0a4ef4bbd4938b5e74dc
- Resolution set to fixed
- Status changed from positive_review to closed