Opened 3 years ago

Last modified 3 years ago

#29229 closed enhancement

Improvements for `is_reflexive` for polyhedra over the integers — at Version 2

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.1
Component: geometry Keywords: polytopes, is_reflexive
Cc: Jean-Philippe Labbé, Laith Rastanawi Merged in:
Authors: Jonathan Kliem Reviewers:
Report Upstream: N/A Work issues:
Branch: public/29229 (Commits, GitHub, GitLab) Commit: 1d7188951925228b0fbf9837542f153115b5cabd
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-kliem)

Currently, this method has almost no documentation.

Also it relies on polar to work differently for Polyhedron_ZZ than for Polyhedron_base. However, this is not being tested at all. We fix this by checking being reflexive just from the inequalities.

This also improves the error messages. We raise a ValueError if the polyhedron is unbounded. If the polytope does not have the origin in the interior, we return False, as this is clearly not reflexive.

Change History (2)

comment:1 Changed 3 years ago by gh-kliem

Branch: public/29229
Commit: 1d7188951925228b0fbf9837542f153115b5cabd
Keywords: polytopes is_reflexive added
Status: newneeds_review

New commits:

1d71889some improvements for `is_reflexive`

comment:2 Changed 3 years ago by gh-kliem

Description: modified (diff)
Note: See TracTickets for help on using tickets.