#29224 closed enhancement (fixed)
`flag_f_vector` for polyhedra
Reported by:  ghkliem  Owned by:  

Priority:  major  Milestone:  sage9.1 
Component:  geometry  Keywords:  polyhedra, flagvector 
Cc:  jipilab, ghLaisRast  Merged in:  
Authors:  Jonathan Kliem, Laith Rastanawi  Reviewers:  JeanPhilippe Labbé 
Report Upstream:  N/A  Work issues:  
Branch:  075c7a8 (Commits, GitHub, GitLab)  Commit:  
Dependencies:  Stopgaps: 
Description
We add a method to Polyhedron_base
and CombinatorialPolyhedron
, which wraps flag_f_polynomial
of FiniteLatticePoset
so that flag_f_vector(1,3)
returns the f_{1,3}.
Change History (8)
comment:1 Changed 2 years ago by
 Branch set to public/29224
 Commit set to fe7d4bbece4fb0911b9c87f74afd07dfe3b01889
 Status changed from new to needs_review
comment:2 Changed 2 years ago by
 Status changed from needs_review to needs_work
A few things:
 In the documentation,
(number of faces of each dimension)
should not say the same as the fvector but say what the flag fvector counts.  Remove the backticks and add dash (in combinatorial polyhedron too):
 Return the `flag_f_vector`. + Return the flag fvector.
 For each `1 < i_0 < \dots < i_n < d` the `flag_f_vector` + For each `1 < i_0 < \dots < i_n < d` the flag fvector
 Backticks missing here (in combinatorial polyhedron file too):
 counts the number of flags `F_0 \subset \dots \subset F_n + counts the number of flags `F_0 \subset \dots \subset F_n`
 Spelling (in combinatorial polyhedron too):
  a dictionary, if no arguments where given    an Integer, if arguments where given +  a dictionary, if no arguments were given + +  an Integer, if arguments were given
comment:3 Changed 2 years ago by
 Commit changed from fe7d4bbece4fb0911b9c87f74afd07dfe3b01889 to 83709e277f7993dd73a12b074243c01153679bc2
Branch pushed to git repo; I updated commit sha1. New commits:
83709e2  typos

comment:4 Changed 2 years ago by
 Status changed from needs_work to needs_review
comment:5 Changed 2 years ago by
 Commit changed from 83709e277f7993dd73a12b074243c01153679bc2 to 075c7a8f5c652a3d1762b488b663cf16932dd6fa
Branch pushed to git repo; I updated commit sha1. New commits:
075c7a8  fixed index error

comment:6 Changed 2 years ago by
 Reviewers set to JeanPhilippe Labbé
 Status changed from needs_review to positive_review
Thanks! It looks good to me now.
comment:7 Changed 2 years ago by
 Branch changed from public/29224 to 075c7a8f5c652a3d1762b488b663cf16932dd6fa
 Resolution set to fixed
 Status changed from positive_review to closed
comment:8 Changed 2 years ago by
 Commit 075c7a8f5c652a3d1762b488b663cf16932dd6fa deleted
Note: See
TracTickets for help on using
tickets.
New commits:
tempory commit
flag_f_vector for combinatorial polyhedron
flagfvector for Polyhedron_base