Opened 20 months ago
Closed 20 months ago
#29223 closed enhancement (fixed)
Pickle cached value of volume and f-vector
Reported by: | gh-kliem | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-9.1 |
Component: | geometry | Keywords: | polyhedron, pickling, volume, f_vector |
Cc: | jipilab, gh-LaisRast | Merged in: | |
Authors: | Jonathan Kliem | Reviewers: | Laith Rastanawi |
Report Upstream: | N/A | Work issues: | |
Branch: | cd13c82 (Commits, GitHub, GitLab) | Commit: | cd13c82fd2dbfb8300ca04b3fb278d7af19daf49 |
Dependencies: | Stopgaps: |
Description (last modified by )
Volume, f-vector and Ehrhart polynomial of polyhedra can be hard to compute, but take little memory when saving.
So we pickle those values, e.g.
+ @cached_method(do_pickle=True) - @cached_method def f_vector(self):
Change History (4)
comment:1 Changed 20 months ago by
- Branch set to public/29223
- Commit set to cd13c82fd2dbfb8300ca04b3fb278d7af19daf49
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 20 months ago by
- Reviewers set to Laith Rastanawi
- Status changed from needs_review to positive_review
It looks good to me. Is there a reason why you did not do the same for functions of CombinatorialPolyhedron??
comment:3 Changed 20 months ago by
Yes, CombinatorialPolyhedron
doesn't exactly pickle. It just reduces, i.e. save enough data to initialize the object again. At some point one could think about a better way of pickling, of course.
comment:4 Changed 20 months ago by
- Branch changed from public/29223 to cd13c82fd2dbfb8300ca04b3fb278d7af19daf49
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
pickle cache of volume, f_vector, ehrhart polynomial
typo