Opened 2 years ago
Closed 2 years ago
#29197 closed defect (fixed)
mcqd needs an update of spkginstall
Reported by:  dimpase  Owned by:  

Priority:  critical  Milestone:  sage9.1 
Component:  packages: optional  Keywords:  
Cc:  dcoudert  Merged in:  
Authors:  Dima Pasechnik  Reviewers:  Matthias Koeppe 
Report Upstream:  N/A  Work issues:  
Branch:  123fa16 (Commits, GitHub, GitLab)  Commit:  123fa16ed135e6349f8605b19c43a281c07778cc 
Dependencies:  Stopgaps: 
Description
otherwise rebuilding Sage 9.1.beta4 with mcqd installed fails at it.
Change History (17)
comment:1 Changed 2 years ago by
 Cc dcoudert added
comment:2 Changed 2 years ago by
 Branch set to u/dimpase/packages/mcqdfix
 Commit set to 6dbca5f8f94ac9e224c5a8343f6a1d979d00f6ee
 Status changed from new to needs_review
 Summary changed from mcqd needs legacy_uninstall, and an update of spkginstall to mcqd needs an update of spkginstall
comment:3 Changed 2 years ago by
I tried on my linux computer and it seems that it fixes the problem (compilation no longer complaining).
I tried on my macOS laptop, but I had to install mcqd first, so it's not a good test. Someone else should try, or tell me which sequence of operation I have to do.
comment:4 Changed 2 years ago by
The branch doesn't touch any files related to mcqd
. Am I missing something?
comment:5 Changed 2 years ago by
try cloning it. it seems that trac is confused.
comment:6 Changed 2 years ago by
 Commit changed from 6dbca5f8f94ac9e224c5a8343f6a1d979d00f6ee to 8151f552f1ff2d7020aa6b7f2c652e268b7443f6
Branch pushed to git repo; I updated commit sha1. New commits:
8151f55  add fPIC, update upstream website

comment:7 Changed 2 years ago by
oops, sorry. now the branch is right
comment:8 Changed 2 years ago by
I can't reproduce any problem with OS X: I took 9.1.beta3, installed mcqd, then did git trac pull develop
to get to 9.1.beta4. make
succeeded.
make
also succeeded with the branch here, and so did ./sage f mcqd
, so it didn't break anything. Is there any reason to bump up the package patchlevel?
comment:9 Changed 2 years ago by
It could be that MacOS just doesn't need fPIC
.
While we're at it, it's good to understand whether mcqd
was updated after out release.
I'll take a look now.
comment:10 Changed 2 years ago by
no, it's the same, only README has changed (becoming README.md, and getting a bit longer).
comment:11 Changed 2 years ago by
 Status changed from needs_review to needs_work
Error confirmed on debianstretchstandardpython2
(https://github.com/mkoeppe/sage/runs/584777841)
Needs rebase.
comment:12 Changed 2 years ago by
 Commit changed from 8151f552f1ff2d7020aa6b7f2c652e268b7443f6 to 123fa16ed135e6349f8605b19c43a281c07778cc
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
123fa16  add fPIC, update upstream website

comment:13 Changed 2 years ago by
 Status changed from needs_work to needs_review
comment:14 Changed 2 years ago by
Thanks! I'll test this
comment:15 Changed 2 years ago by
 Reviewers set to Matthias Koeppe
comment:16 Changed 2 years ago by
 Status changed from needs_review to positive_review
Installation seems to work well. https://github.com/mkoeppe/sage/runs/589959544
comment:17 Changed 2 years ago by
 Branch changed from u/dimpase/packages/mcqdfix to 123fa16ed135e6349f8605b19c43a281c07778cc
 Resolution set to fixed
 Status changed from positive_review to closed
please test on MacOS in particular
It would also be interesting to find out whether the new upstream gitlab repo for the package has any updates (and then we should apply thhem).