Opened 6 months ago

Closed 6 months ago

#29168 closed enhancement (fixed)

less unused imports and better .lgtm config file

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-9.1
Component: refactoring Keywords:
Cc: tscrim, jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: a5cfb4c (Commits) Commit: a5cfb4cfaee5b9c8463410dd9d9088a81ed055de
Dependencies: Stopgaps:

Description


Change History (5)

comment:1 Changed 6 months ago by chapoton

  • Branch set to u/chapoton/29168
  • Cc tscrim jmantysalo added
  • Commit set to a9e75cfa772878b982b77c1122b84ec74b1c5678
  • Status changed from new to needs_review

New commits:

a9e75cfless unused imports and better .lgtm file

comment:2 Changed 6 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

I think if you are going to move the imports for the classical Lie algebras, you should also put the assert statements together. It also makes it more localized/grouped for the pyflakes silencing code. Once changed, you can set a positive review.

comment:3 Changed 6 months ago by git

  • Commit changed from a9e75cfa772878b982b77c1122b84ec74b1c5678 to a5cfb4cfaee5b9c8463410dd9d9088a81ed055de

Branch pushed to git repo; I updated commit sha1. New commits:

a5cfb4cdetail for 29168

comment:4 Changed 6 months ago by tscrim

  • Status changed from needs_review to positive_review

Thanks LGTM.

comment:5 Changed 6 months ago by vbraun

  • Branch changed from u/chapoton/29168 to a5cfb4cfaee5b9c8463410dd9d9088a81ed055de
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.