#29155 closed enhancement (fixed)

Full-dimensional face of Polyhedron should have equations

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.1
Component: geometry Keywords: polytopes, universe face, equations
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: d7f47ad (Commits, GitHub, GitLab) Commit: d7f47ad61838e9fe9b1cb866a1ea9d7925a0b03a
Dependencies: Stopgaps:

Status badges

Description

Currently in a Polyhedron with lines, the full-dimensional face is initialized without equations:

A 2-dimensional face of a Polyhedron in ZZ^3 defined as the convex hull of 6 vertices
sage: P = polytopes.permutahedron(3)
sage: [f] = P.face_generator(2)
sage: f
A 2-dimensional face of a Polyhedron in ZZ^3 defined as the convex hull of 6 vertices
sage: f.ambient_Hrepresentation()
()

This is a bug from #28646 (probably introduced there). We fix this:

sage: P = polytopes.permutahedron(3)
sage: [f] = P.face_generator(2)
sage: f.ambient_Hrepresentation()
(An equation (1, 1, 1) x - 6 == 0,)

Change History (3)

comment:1 Changed 18 months ago by gh-kliem

  • Branch set to public/29155
  • Commit set to d7f47ad61838e9fe9b1cb866a1ea9d7925a0b03a
  • Status changed from new to needs_review

New commits:

d7f47adinitialize full-dimensional face with equations

comment:2 Changed 18 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 18 months ago by vbraun

  • Branch changed from public/29155 to d7f47ad61838e9fe9b1cb866a1ea9d7925a0b03a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.