Opened 2 years ago

Closed 11 months ago

#29152 closed defect (fixed)

Cygwin: Fix cliquer, giac, meataxe, rw, libbraiding to build shared libraries, using `AM_LDFLAGS=-no-undefined`

Reported by: embray Owned by: embray
Priority: critical Milestone: sage-9.3
Component: porting: Cygwin Keywords:
Cc: ​SimonKing, mmarco, dimpase, mjo, arojas, fbissey, slelievre, jhpalmieri, vbraun Merged in:
Authors: Matthias Koeppe, Miguel Marco, Simon King Reviewers: Matthias Koeppe, Dima Pasechnik
Report Upstream: Reported upstream. No feedback yet. Work issues:
Branch: 6b6ee5c (Commits, GitHub, GitLab) Commit: 6b6ee5c42603c0467da76f0478a399bab19dfc5b
Dependencies: #31064 Stopgaps:

Status badges

Description (last modified by mjo)

Follow-up from #30396, where libtool's fallback to static library build for giac caused linker errors while building sagelib.

This is fixed by passing -no-undefined to the libtool linking flags, by setting AM_LDFLAGS=-no-undefined.

Affected packages can be found as follows:

$ grep "undefined symbols not allowed" logs/pkgs/*
cliquer-1.21.p4.log:libtool: link: warning: undefined symbols not allowed in x86_64-unknown-cygwin shared libraries
giac-1.5.0.87p0.log:libtool: warning: undefined symbols not allowed in x86_64-pc-cygwin shared libraries; building static only
libbraiding-1.0.p0.log:libtool: warning: undefined symbols not allowed in x86_64-unknown-cygwin shared libraries; building static only
rw-0.7.p0.log:libtool: link: warning: undefined symbols not allowed in x86_64-unknown-cygwin shared libraries
singular-4.1.1p2.p0.log:libtool: warning: undefined symbols not allowed in x86_64-unknown-cygwin shared libraries; building static only

In singular, only the gitfan.la library (module) is affected:

Making all in gitfan
...
/usr/bin/bash ../../../libtool  --tag=CXX   --mode=link g++ -std=gnu++11  -O2 -g  -pipe -fno-common -g0 -O3 -Wno-unused-function -Wno-trigraphs -Wno-unused-parameter -Wunknown-pragmas -Wno-unused-variable -fomit-frame-pointer -fwrapv -fvisibility=default -finline-functions -fno-exceptions -fno-threadsafe-statics -fno-enforce-eh-specs -fconserve-space -funroll-loops -fno-delete-null-pointer-checks -fno-rtti -module -export-dynamic -avoid-version -flat_namespace -weak_reference_mismatches weak -undefined dynamic_lookup -L/cygdrive/d/a/sage/sage/local/lib -Wl,-rpath,/cygdrive/d/a/sage/sage/local/lib  -pipe -fno-common -g0 -O3 -Wno-unused-function -Wno-trigraphs -Wno-unused-parameter -Wunknown-pragmas -Wno-unused-variable -fomit-frame-pointer -fwrapv -fvisibility=default -finline-functions -fno-exceptions -fconserve-space -funroll-loops -fno-delete-null-pointer-checks  -Wl,-Bdynamic -o gitfan.la -rpath /cygdrive/d/a/sage/sage/local/libexec/singular/MOD gitfan_la-gitfan.lo  -lreadline -lncurses -lmpfr -lrt
libtool: warning: undefined symbols not allowed in x86_64-unknown-cygwin shared libraries; building static only
libtool: link: ar cru .libs/gitfan.a  gitfan_la-gitfan.o
libtool: link: ranlib .libs/gitfan.a
libtool: link: ( cd ".libs" && rm -f "gitfan.la" && ln -s "../gitfan.la" "gitfan.la" )

The issue also affects the optional package meataxe.

[meataxe-1.0.p0] /usr/bin/bash ../libtool  --tag=CC   --mode=link gcc  -g -O2  -L/opt/sagemath-9.0/local/lib -Wl,-rpath,/opt/sagemath-9.0/local/lib  -o libmtx.la -rpath /opt/sagemath-9.0/local/lib args.lo berlekmp.lo bsand.lo bscore.lo bsdup.lo bsissub.lo bsmatch.lo bsminus.lo bsop.lo bsor.lo bsprint.lo bsread.lo bswrite.lo cfinfo.lo charpol.lo chbasis.lo error.lo ffio.lo fpcore.lo fpdup.lo fpmul.lo fpmul2.lo fpprint.lo gcd.lo genseed.lo grmaprow.lo grmatcore.lo grtable.lo homcomp.lo imatcore.lo imatread.lo imatwrite.lo init.lo intio.lo issub.lo isisom.lo kernel-0.lo ldiag.lo maddmul.lo mat2vec.lo matadd.lo matclean.lo matcmp.lo maketabF.lo matcopy.lo matcore.lo matcut.lo matdup.lo matech.lo matid.lo matins.lo matinv.lo matmul.lo matnull.lo matorder.lo matpivot.lo matprint.lo matpwr.lo matread.lo mattr.lo mattrace.lo matwrite.lo message.lo mfcore.lo mfread.lo mfreadlong.lo mfwrite.lo mfwritelong.lo minpol.lo mkendo.lo mmulscal.lo mraddgen.lo mrcore.lo mrread.lo mrtranspose.lo mrwrite.lo msclean.lo mscore.lo mtensor.lo mtxobj.lo os.lo permcmp.lo permcore.lo permdup.lo perminv.lo permmul.lo permorder.lo permprint.lo permpwr.lo permread.lo permwrite.lo poladd.lo polcmp.lo polcore.lo polderive.lo poldiv.lo poldup.lo polgcd.lo polmul.lo polprint.lo polread.lo polwrite.lo quotient.lo random.lo rdcfgen.lo saction.lo setcore.lo setinsert.lo settest.lo spinup.lo spinup2.lo split.lo stabpwr.lo stfcore.lo stfread.lo stfwrite.lo string.lo sumint.lo temap.lo tkinfo.lo vec2mat.lo wgen.lo window.lo zcleanrow.lo zcmprow.lo zgap.lo zpermrow.lo zzz2.lo
[meataxe-1.0.p0] libtool:   error: can't build x86_64-unknown-cygwin shared library unless -no-undefined is specified

This is a common issue especially when using libtool to link Windows DLLs and should hopefully be straightforward to fix.

See also:

  • #30271 nauty: Switch to autotoolized fork so that shared libraries can be built

Change History (73)

comment:1 Changed 2 years ago by embray

  • Owner changed from (none) to embray

comment:2 Changed 21 months ago by mkoeppe

  • Cc ​SimonKing added
  • Component changed from packages: optional to porting: Cygwin

comment:3 Changed 21 months ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-9.2

comment:4 Changed 17 months ago by mkoeppe

  • Description modified (diff)
  • Priority changed from major to critical
  • Summary changed from Optional package meataxe doesn't build on Cygwin to Cygwin: Make sure all package build shared libraries, using `AM_LDFLAGS=-no-undefined`

comment:5 Changed 17 months ago by mkoeppe

  • Cc mmarco added

Cc'ing mmarco re libbraiding

comment:6 follow-ups: Changed 17 months ago by mkoeppe

  • Cc dimpase added
  • Report Upstream changed from N/A to Reported upstream. No feedback yet.

cc'ing dimpase re cliquer, also reported at https://github.com/dimpase/autocliquer/issues/4

comment:7 Changed 17 months ago by mkoeppe

Upstream link in build/pkgs/rw/SPKG.rst no longer works

comment:8 Changed 17 months ago by mkoeppe

  • Cc mjo arojas fbissey added

Cc'ing gentoo, arch people to see if new rw upstream is known

comment:9 Changed 17 months ago by mkoeppe

  • Summary changed from Cygwin: Make sure all package build shared libraries, using `AM_LDFLAGS=-no-undefined` to Cygwin: Make sure all packages build shared libraries, using `AM_LDFLAGS=-no-undefined`

comment:10 follow-up: Changed 17 months ago by arojas

I'm getting it from https://sourceforge.net/projects/rankwidth/, but I don't know if there's anybody reading tickets there (there are none filed so far)

comment:11 in reply to: ↑ 10 Changed 17 months ago by fbissey

Replying to arojas:

I'm getting it from https://sourceforge.net/projects/rankwidth/, but I don't know if there's anybody reading tickets there (there are none filed so far)

Same here in Gentoo https://packages.gentoo.org/packages/sci-mathematics/rw

comment:12 follow-up: Changed 17 months ago by mjo

What's wrong with rw upstream? The program is more or less "complete," so I wouldn't expect much activity. Last time (a few years ago), we just emailed the guy to ask about contributing an autotools build system.

comment:13 Changed 17 months ago by mkoeppe

  • Branch set to u/mkoeppe/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_

comment:14 in reply to: ↑ 12 Changed 17 months ago by mkoeppe

  • Commit set to 45a4167153f9cb4cd46a0f06d53d6aad0a37db8a

Replying to mjo:

What's wrong with rw upstream?

See ticket description


New commits:

45a4167build/pkgs/rw/SPKG.rst: Update link to upstream project

comment:15 follow-up: Changed 17 months ago by mmarco

I created a new release for libbraiding:

https://github.com/miguelmarco/libbraiding/releases/tag/1.1

Should I also update the sage package?

IIRC, there is a new way to upload the tarball. Isn't it?

comment:16 in reply to: ↑ 15 Changed 17 months ago by mkoeppe

Replying to mmarco:

I created a new release for libbraiding:

https://github.com/miguelmarco/libbraiding/releases/tag/1.1

Thanks a lot!

Should I also update the sage package?

Yes please

IIRC, there is a new way to upload the tarball. Isn't it?

No need to upload, but please add upstream_url as explained in https://wiki.sagemath.org/ReleaseTours/sage-9.1#For_developers-1

comment:17 Changed 17 months ago by mmarco

  • Branch changed from u/mkoeppe/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_ to u/mmarco/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_

comment:18 Changed 17 months ago by mkoeppe

  • Authors set to Matthias Koeppe, Miguel Marco
  • Commit changed from 45a4167153f9cb4cd46a0f06d53d6aad0a37db8a to 44839c79c0763314c08e40b7e6bb01a485ca21f1
  • Description modified (diff)

New commits:

44839c7libbraiding version bump

comment:19 Changed 17 months ago by mkoeppe

  • Description modified (diff)

comment:20 Changed 17 months ago by mkoeppe

  • Branch changed from u/mmarco/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_ to u/mkoeppe/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_

comment:21 Changed 17 months ago by mkoeppe

  • Commit changed from 44839c79c0763314c08e40b7e6bb01a485ca21f1 to b2c0b15ef053c101876754f48a9840cf4f10acbd

Fix for meataxe at https://github.com/simon-king-jena/SharedMeatAxe/pull/1


New commits:

b2c0b15build/pkgs/meataxe/distros: Add fedora.txt

comment:22 in reply to: ↑ 6 Changed 17 months ago by mkoeppe

comment:24 Changed 17 months ago by mkoeppe

  • Description modified (diff)

comment:25 Changed 17 months ago by mkoeppe

Looks like the singular gitfan issue may be fixed by upstream commit 2617fca625d047a0b9890e6ffae1c5f8fe755aad

comment:26 follow-ups: Changed 17 months ago by mjo

  • Description modified (diff)

The -no-undefined is only needed when building a shared library, so the flag can be appended in e.g.

libfoo_la_LDFLAGS = -no-undefined

rather than the global

AM_LDFLAGS=-no-undefined

that will affect all link operations (including executables). It probably doesn't hurt much, but I remember vaguely that --as-needed was nicer than --no-undefined if you were going to apply it globally.

I also think most projects should have LT_INIT([disable-static]) in configure.ac these days, to disable the static libraries by default. They can still be enabled with --enable-static, but for most people they're a waste of time/space.

comment:27 Changed 17 months ago by mjo

  • Description modified (diff)

Putting back the description I clobbered...

comment:28 in reply to: ↑ 26 Changed 17 months ago by mkoeppe

Replying to mjo:

The -no-undefined is only needed when building a shared library, so the flag can be appended in e.g.

libfoo_la_LDFLAGS = -no-undefined

rather than the global

AM_LDFLAGS=-no-undefined

that will affect all link operations

I agree, that would be a little bit cleaner. But I don't think it's worth going back for this

comment:29 in reply to: ↑ 26 Changed 17 months ago by mkoeppe

Replying to mjo:

I also think most projects should have LT_INIT([disable-static]) in configure.ac these days, to disable the static libraries by default. They can still be enabled with --enable-static, but for most people they're a waste of time/space.

I agree, but I want to keep the upstream patches minimal. We have #28890 for the task of sending --disable-static to all our packages

comment:30 in reply to: ↑ 6 Changed 17 months ago by dimpase

Replying to mkoeppe:

cc'ing dimpase re cliquer, also reported at https://github.com/dimpase/autocliquer/issues/4

OK, done and dusted, thanks for the PR, see https://github.com/dimpase/autocliquer/releases/download/v1.22/cliquer-1.22.tar.gz

comment:31 Changed 17 months ago by git

  • Commit changed from b2c0b15ef053c101876754f48a9840cf4f10acbd to 1e94f7a730e6f8bca1015970372fe13f25e5f6a7

Branch pushed to git repo; I updated commit sha1. New commits:

1e94f7abuild/pkgs/cliquer: Update to 1.22

comment:32 Changed 17 months ago by dimpase

could you also add

  • build/pkgs/cliquer/SPKG.rst

    a b Description 
    55-----------
    66
    77Cliquer is a set of C routines for finding cliques in an arbitrary
    8 weighted graph. It uses an exact branch-and-bound algorithm recently
    9 developed by Patr Ostergard.
     8weighted graph. It uses an exact branch-and-bound algorithm
     9developed by Patric Östergård.
    1010
    1111License
    1212-------
    Dependencies 
    2828Patches
    2929-------
    3030
    31 -  autotoolized - see https://github.com/dimpase/autocliquer
     31-  minor config updates (v1.22)
     32-  autotoolized - see https://github.com/dimpase/autocliquer (v1.21)

comment:33 Changed 17 months ago by git

  • Commit changed from 1e94f7a730e6f8bca1015970372fe13f25e5f6a7 to f2632eb7f50745c9e02b7a82789d68bed6b30373

Branch pushed to git repo; I updated commit sha1. New commits:

f2632ebbuild/pkgs/cliquer/SPKG.rst: Update

comment:34 Changed 17 months ago by git

  • Commit changed from f2632eb7f50745c9e02b7a82789d68bed6b30373 to 9c1ee3787415d4730687ea193e139471e422c361

Branch pushed to git repo; I updated commit sha1. New commits:

9c1ee37build/pkgs/rw: Update to 0.9

comment:35 Changed 16 months ago by git

  • Commit changed from 9c1ee3787415d4730687ea193e139471e422c361 to e662986500556f2f122ea861c55517c40fe50c5f

Branch pushed to git repo; I updated commit sha1. New commits:

e662986Merge tag '9.2.beta14' into t/29152/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_

comment:36 Changed 16 months ago by mkoeppe

  • Status changed from new to needs_review

comment:37 Changed 16 months ago by SimonKing

I am about to release a new minor version of SharedMeatAxe based on Matthias' suggestions, and my plan was to upgrade it in Sage now. But since it is "needs review" already: Did Matthias did the meataxe upgrade in Sage already?

comment:38 Changed 16 months ago by SimonKing

  • Status changed from needs_review to needs_work
  • Work issues set to Upgrade shared_meataxe to v1.0.1

Aparently the upgrade of meataxe hasn't been done yet. So, it should be "needs work".

comment:39 Changed 16 months ago by SimonKing

  • Branch changed from u/mkoeppe/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_ to u/SimonKing/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_

comment:40 Changed 16 months ago by SimonKing

  • Commit changed from e662986500556f2f122ea861c55517c40fe50c5f to 54c258463a7ad313c222b4007503dd0cfc56b67b
  • Status changed from needs_work to needs_review
  • Work issues Upgrade shared_meataxe to v1.0.1 deleted

SharedMeatAxe is upgraded as well. See https://github.com/simon-king-jena/SharedMeatAxe/releases/tag/v1.0.1

I changed the compression from gz to bz2, since the latter gives a smaller tar ball. Self tests pass, I'm running "make test" now.


New commits:

54c2584Upgrade SharedMeatAxe, to fix a build problem on Cygwin

comment:41 Changed 16 months ago by SimonKing

  • Authors changed from Matthias Koeppe, Miguel Marco to Matthias Koeppe, Miguel Marco, Simon King

Tests pass for me. However, the point of this ticket is to fix things on cygwin, which I'm not using.

Hence, no positive review.

A question: Is it still the case that the issues are "Reported upstream. No feedback yet.", or can this be changed to "Fixed upstream"?

comment:42 Changed 16 months ago by mkoeppe

Thanks very much, Simon. Could you add an upstream_url field to checksums.ini please (as explained in https://wiki.sagemath.org/ReleaseTours/sage-9.1#For_developers-1)

comment:43 Changed 16 months ago by git

  • Commit changed from 54c258463a7ad313c222b4007503dd0cfc56b67b to cd74ef3fffce5f71a6a8a53c62638fda6ee34ec6

Branch pushed to git repo; I updated commit sha1. New commits:

cd74ef3Add upstream url for SharedMeatAxe

comment:44 Changed 16 months ago by SimonKing

Hope that upstream_url for SharedMeatAxe is fine.

comment:45 follow-up: Changed 16 months ago by mkoeppe

  • Reviewers set to https://github.com/mkoeppe/sage/actions/runs/285244461

comment:46 in reply to: ↑ 45 ; follow-up: Changed 16 months ago by SimonKing

Replying to mkoeppe:

You added a URL as reviewer. Is that intended?

Actually it is not clear to me what is stated there. Do I understand correctly that tests on different versions of Cygwin pass, except "cygwin-stage-ii-a (standard)"? And the failed package in this Cygwin version is scipy?

comment:47 in reply to: ↑ 46 ; follow-up: Changed 16 months ago by mkoeppe

Replying to SimonKing:

Replying to mkoeppe:

You added a URL as reviewer. Is that intended?

Yes, it's a trick that I have been using recently. The URL shows in ticket lists such as https://trac.sagemath.org/report/92?asc=1&page=1 and this reminds me (or other developers) to inspect these automatic builds when they are done.

They will be replaced by actual reviewer names when ready.

Actually it is not clear to me what is stated there. Do I understand correctly that tests on different versions of Cygwin pass, except "cygwin-stage-ii-a (standard)"? And the failed package in this Cygwin version is scipy?

The build on Cygwin takes very long because of various overheads compared to a build on Linux. On GH Actions there is a time limit of 6 hours per job. Therefore I have split the build into several jobs ("stages"), some of which run in parallel. The linked build https://github.com/mkoeppe/sage/actions/runs/285244461 is the cygwin-standard build, which means that I install binary packages from the Cygwin distribution first and then start the build of Sage.

stage-i-a and stage-i-b ran in parallel and succeeded. What they install in SAGE_LOCAL is carried forward to stage-ii. The 5 jobs stage-ii-a to stage-ii-e all ran in parallel, building various packages.

As you observed, stage-ii-a failed because of scipy. This is a bug unrelated to the present ticket; it is tracked in #30643. Unfortunately this bug blocks the following stages (stage-iii would go on to build the Sage library), and so because of this we cannot really check that the current ticket is working correctly.

Last edited 16 months ago by mkoeppe (previous) (diff)

comment:48 in reply to: ↑ 47 ; follow-up: Changed 16 months ago by SimonKing

Replying to mkoeppe:

Unfortunately this bug blocks the following stages (stage-iii would go on to build the Sage library), and so because of this we cannot really check that the current ticket is working correctly.

We cannot test automatically (on github), but a developer with a cygwin machine certainly could...

comment:49 Changed 16 months ago by mkoeppe

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/285244461 to https://github.com/mkoeppe/sage/actions/runs/287249195

comment:50 Changed 16 months ago by mkoeppe

  • Branch changed from u/SimonKing/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_ to u/mkoeppe/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_

comment:51 in reply to: ↑ 48 Changed 16 months ago by mkoeppe

  • Commit changed from cd74ef3fffce5f71a6a8a53c62638fda6ee34ec6 to e41329adfa1f1e69653ba127d6460d2bd7aaaf00

Replying to SimonKing:

We cannot test automatically (on github), but a developer with a cygwin machine certainly could...

We seem to be in short supply of these...

I have modified the CI script so that the scipy failure does not stop the whole build.

The resulting build logs (https://github.com/mkoeppe/sage/suites/1285136303/artifacts/20016238) show that cliquer, giac, meataxe, and rw, i.e., all packages mentioned in the ticket description except for libbraiding (for which the branch contains an update) and singular (for which the branch does not contain a change) are OK now. Some optional packages were not built previously. In total, we now have the following remaining issues:

egret:~/Downloads/logs-commit-e41329adfa1f1e69653ba127d6460d2bd7aaaf00-cygwin-standard$ grep "undefined symbols not allowed" pkgs/*
pkgs/barvinok-0.41.1.log:libtool: warning: undefined symbols not allowed in x86_64-unknown-cygwin shared libraries; building static only
pkgs/e_antic-0.1.8.log:libtool: warning: undefined symbols not allowed in x86_64-pc-cygwin shared libraries; building static only
pkgs/isl-0.20.log:libtool: warning: undefined symbols not allowed in x86_64-unknown-cygwin shared libraries; building static only
pkgs/libbraiding-1.1.log:libtool: warning: undefined symbols not allowed in x86_64-pc-cygwin shared libraries; building static only
pkgs/polylib-5.22.5.log:libtool: link: warning: undefined symbols not allowed in x86_64-unknown-cygwin shared libraries
pkgs/singular-4.1.1p2.p0.log:libtool: warning: undefined symbols not allowed in x86_64-unknown-cy(base) eg(ba(base) egr(ba(base) egret(ba(base) (base)(base)(bas(b(bas(base)(((b((

New commits:

e41329aci-cygwin-standard.yml: More stages, continue-on-error: true

comment:52 Changed 16 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:53 Changed 15 months ago by mkoeppe

  • Summary changed from Cygwin: Make sure all packages build shared libraries, using `AM_LDFLAGS=-no-undefined` to Cygwin: Fix cliquer, giac, meataxe, rw, libbraiding to build shared libraries, using `AM_LDFLAGS=-no-undefined`

Let's get this in so that other tickets can use it as a dependency.

Follow up for the remaining issues in #30814.

comment:54 Changed 15 months ago by mkoeppe

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/287249195 to https://github.com/mkoeppe/sage/actions/runs/287249195, ...

comment:55 Changed 15 months ago by mkoeppe

Needs review

comment:56 follow-up: Changed 15 months ago by dimpase

there seems to be some problem with building of scipy

 In file included from /usr/include/sys/config.h:5,
                   from /usr/include/_ansi.h:11,
                   from /usr/include/sys/reent.h:13,
                   from /usr/include/math.h:5,
                   from /usr/lib/gcc/x86_64-pc-cygwin/10/include/c++/cmath:45,
                   from scipy/spatial/ckdtree/src/query.cxx:1:
  /usr/include/sys/features.h:255: note: this is the location of the previous definition
    255 | #define __BSD_VISIBLE  0
        |
  In file included from /cygdrive/d/a/sage/sage/local/include/python3.8/pyport.h:219,
                   from /cygdrive/d/a/sage/sage/local/include/python3.8/Python.h:63,
                   from /cygdrive/d/a/sage/sage/local/lib/python3.8/site-packages/numpy/core/include/numpy/npy_common.h:11,
                   from scipy/spatial/ckdtree/src/ckdtree_decl.h:10,
                   from scipy/spatial/ckdtree/src/query.cxx:13:
  /usr/include/sys/time.h:106:34: error: 'u_int' has not been declared
    106 | bintime_mul(struct bintime *_bt, u_int _x)
        |                                  ^~~~~
  g++: scipy/spatial/ckdtree/src/build.cxx

comment:57 Changed 14 months ago by mkoeppe

  • Dependencies set to #30154

comment:58 Changed 14 months ago by git

  • Commit changed from e41329adfa1f1e69653ba127d6460d2bd7aaaf00 to 96610658a37c808a5785c0c434a194e161bd30f6

Branch pushed to git repo; I updated commit sha1. New commits:

0bb7fc0Merge tag '9.3.beta3' into t/29152/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_
7244a9dci-cygwin-standard.yml: Use tar --listed-incremental
5ccf1eatar --remove-files and --listed-incremental are not compatible
9661065Merge branch 't/30154/gh_actions__cygwin__use_incremental_archives_for_the_sage_local_artifact' into t/29152/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_

comment:59 in reply to: ↑ 56 Changed 14 months ago by mkoeppe

Replying to dimpase:

there seems to be some problem with building of scipy

  /usr/include/sys/time.h:106:34: error: 'u_int' has not been declared

Probably fixed in #30643

comment:60 Changed 14 months ago by mkoeppe

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/287249195, ... to https://github.com/mkoeppe/sage/actions/runs/412156307, ...

comment:61 Changed 14 months ago by git

  • Commit changed from 96610658a37c808a5785c0c434a194e161bd30f6 to 4c34a0e87c2be229bb394bc0cf9029328f7c2c4d

Branch pushed to git repo; I updated commit sha1. New commits:

4c34a0eUpdate ci-cygwin-minimal.yml

comment:62 Changed 13 months ago by mkoeppe

  • Status changed from needs_review to needs_work
  • Work issues set to rebase on top of #31064

comment:63 Changed 13 months ago by git

  • Commit changed from 4c34a0e87c2be229bb394bc0cf9029328f7c2c4d to 58c22df464d18bd03d1f4e19043099fa53541072

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

cea4cd5ci-cygwin-standard.yml: More stages, continue-on-error: true
cf31b79Fixup after cherry-pick
73b0e8fbuild/pkgs/rw/SPKG.rst: Update link to upstream project
9d724bclibbraiding version bump
a67a446build/pkgs/meataxe/distros: Add fedora.txt
c79da6abuild/pkgs/cliquer: Update to 1.22
b5dcb16build/pkgs/cliquer/SPKG.rst: Update
9e6de0bbuild/pkgs/rw: Update to 0.9
32385deUpgrade SharedMeatAxe, to fix a build problem on Cygwin
58c22dfAdd upstream url for SharedMeatAxe

comment:64 Changed 13 months ago by mkoeppe

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/412156307, ... to Matthias Koeppe, https://github.com/mkoeppe/sage/actions/runs/432820484, ...
  • Status changed from needs_work to needs_review
  • Work issues rebase on top of #31064 deleted

comment:65 Changed 13 months ago by mkoeppe

  • Dependencies changed from #30154 to #31064

comment:66 Changed 13 months ago by git

  • Commit changed from 58c22df464d18bd03d1f4e19043099fa53541072 to c2daec7767860d1bb8ed0bc7fe83d4d3b6c0cf8a

Branch pushed to git repo; I updated commit sha1. New commits:

09d1737Makefile: Add targets ptest-nodoc etc.
0dca776Merge branch 't/29124/script-packages-prereq-toolchain-bootstrap' into t/31084/makefile__add__ptest__targets_that_do_not_depend_on_the_docbuild
073124cMerge branch 't/31084/makefile__add__ptest__targets_that_do_not_depend_on_the_docbuild' into t/31064/ci_cygwin__yml__adjust_to_new_script_packages__bootstrap___prereq
8769bd6.github/workflows/ci-cygwin-*.yml: Separate docbuild and ptest
c2daec7Merge branch 't/31064/ci_cygwin__yml__adjust_to_new_script_packages__bootstrap___prereq' into t/29152/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_

comment:67 Changed 13 months ago by git

  • Commit changed from c2daec7767860d1bb8ed0bc7fe83d4d3b6c0cf8a to 76804dcb31f396852de158c1ac9650b43cdecb59

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

78ff9d5src/sage/misc/package.py: Add one more # optional - build
a44042fMerge branch 't/30940/src_bin_sage_list_packages__make_it_work_if_sage_root_is_not_available' into t/29124/script-packages-prereq-toolchain-bootstrap
64bde5fMerge tag '9.3.beta5' into t/30940/src_bin_sage_list_packages__make_it_work_if_sage_root_is_not_available
e9a7572src/sage/misc/package.py: Improve source formatting
c7bcda9Merge branch 't/30940/src_bin_sage_list_packages__make_it_work_if_sage_root_is_not_available' into t/29124/script-packages-prereq-toolchain-bootstrap
9988c5fci-cygwin*.yml: Adjust to new script packages _bootstrap, _prereq
d65299cMerge branch 't/29124/script-packages-prereq-toolchain-bootstrap' into t/31064/ci_cygwin__yml__adjust_to_new_script_packages__bootstrap___prereq
ab19133Merge branch 't/29124/script-packages-prereq-toolchain-bootstrap' into t/30944/tox__improve_local_sudo_ubuntu_standard
a5e4051Merge branch 't/30944/tox__improve_local_sudo_ubuntu_standard' into t/31064/ci_cygwin__yml__adjust_to_new_script_packages__bootstrap___prereq
76804dcMerge branch 't/31064/ci_cygwin__yml__adjust_to_new_script_packages__bootstrap___prereq' into t/29152/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_

comment:68 Changed 12 months ago by mkoeppe

  • Cc slelievre jhpalmieri vbraun added

Let's please get this in.

comment:69 Changed 12 months ago by dimpase

  • Reviewers changed from Matthias Koeppe, https://github.com/mkoeppe/sage/actions/runs/432820484, ... to Matthias Koeppe, Dima Pasechnik
  • Status changed from needs_review to positive_review

It still doesn't fix all the Cygwin things, no? Anyway, LGTM.

comment:70 Changed 12 months ago by mkoeppe

Thank you!

Follow up for the remaining issues in #30814.

comment:71 Changed 12 months ago by git

  • Commit changed from 76804dcb31f396852de158c1ac9650b43cdecb59 to 6b6ee5c42603c0467da76f0478a399bab19dfc5b
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

42f4458Merge tag '9.3.beta7' into t/31064/ci_cygwin__yml__adjust_to_new_script_packages__bootstrap___prereq
6b6ee5cMerge branch 't/31064/ci_cygwin__yml__adjust_to_new_script_packages__bootstrap___prereq' into t/29152/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_

comment:72 Changed 12 months ago by mkoeppe

  • Status changed from needs_review to positive_review

comment:73 Changed 11 months ago by vbraun

  • Branch changed from u/mkoeppe/cygwin__make_sure_all_packages_build_shared_libraries__using__am_ldflags__no_undefined_ to 6b6ee5c42603c0467da76f0478a399bab19dfc5b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.