Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#29126 closed enhancement (fixed)

Add a lmfdb_page function for number fields

Reported by: alexjbest Owned by:
Priority: major Milestone: sage-9.1
Component: number fields Keywords: lmfdb
Cc: Merged in:
Authors: Alex J. Best Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 3051fcc (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

In #21533 a convenience function was added to elliptic curves to open the corresponding page on the lmfdb which can contain information which is non-trivial to recompute in sage on the fly.

This ticket adds the corresponding thing for number fields.

Suggestions for other objects both in Sage and the LMFDB where something similar could be added would be great and can be added to this ticket.

Change History (20)

comment:1 Changed 2 years ago by alexjbest

  • Branch set to public/29126
  • Commit set to f0ae571d17e685258c1de89c2a29953f4d8fb302

comment:2 Changed 2 years ago by alexjbest

  • Branch changed from public/29126 to u/alexjbest/29126

comment:3 Changed 2 years ago by alexjbest

  • Branch u/alexjbest/29126 deleted
  • Commit f0ae571d17e685258c1de89c2a29953f4d8fb302 deleted

comment:4 Changed 2 years ago by alexjbest

  • Branch set to u/alexjbest/29126
  • Commit set to f0ae571d17e685258c1de89c2a29953f4d8fb302

comment:5 Changed 2 years ago by alexjbest

  • Branch changed from u/alexjbest/29126 to u/alexjbest/lmfdb-page

comment:6 Changed 2 years ago by alexjbest

ok

Last edited 2 years ago by alexjbest (previous) (diff)

comment:7 Changed 2 years ago by git

  • Commit changed from f0ae571d17e685258c1de89c2a29953f4d8fb302 to 936e65bc2b831f253046bb5a8a72f58656dd64fa

Branch pushed to git repo; I updated commit sha1. New commits:

936e65badd lmfdb_page function for number fields

comment:8 Changed 2 years ago by git

  • Commit changed from 936e65bc2b831f253046bb5a8a72f58656dd64fa to 81508582ae16ba75152fc20b811f2c6cceb9bb9d

Branch pushed to git repo; I updated commit sha1. New commits:

8150858fix

comment:9 Changed 2 years ago by git

  • Commit changed from 81508582ae16ba75152fc20b811f2c6cceb9bb9d to 035234760b2cbb32d6e5afeb328c217db84a6f64

Branch pushed to git repo; I updated commit sha1. New commits:

0352347variable names

comment:10 Changed 2 years ago by chapoton

you should use "https" everywhere, if it works

comment:11 Changed 2 years ago by alexjbest

It does work. But I believe http redirects to https.

comment:12 Changed 2 years ago by git

  • Commit changed from 035234760b2cbb32d6e5afeb328c217db84a6f64 to 2bc95b5ba3a6798fc8a40d52975c168a528ad4b1

Branch pushed to git repo; I updated commit sha1. New commits:

2bc95b5use https

comment:13 Changed 2 years ago by chapoton

This does not work at all on python3-sage:

AttributeError: module 'urllib' has no attribute 'quote'

Are you using the most recent sage for development, as strongly advised ?

comment:14 Changed 2 years ago by chapoton

  • Branch changed from u/alexjbest/lmfdb-page to public/ticket/29126
  • Commit changed from 2bc95b5ba3a6798fc8a40d52975c168a528ad4b1 to 3051fcc78d101b278f2e0fe65887e7afb9ad7e3f
  • Reviewers set to Frédéric Chapoton
  • Status changed from new to needs_review

Here is a better branch, working with sage 9.0. If you agree, you can set to positive


New commits:

3051fccadd lmfdb_page function for number fields

comment:15 Changed 2 years ago by alexjbest

I'm a little confused what is different in my sage install, I based it off 9.1beta2 according to my git log, maybe I should have make distcleaned or something. But if the patchbots happy I will set positive.

comment:16 Changed 2 years ago by chapoton

The command "banner()" tells you if you are running python2 or python3.

comment:17 Changed 2 years ago by chapoton

patchbots are indeed happy

comment:18 Changed 2 years ago by alexjbest

  • Status changed from needs_review to positive_review

Ok I just double checked on my machine python3 now looks good!

comment:19 Changed 2 years ago by vbraun

  • Branch changed from public/ticket/29126 to 3051fcc78d101b278f2e0fe65887e7afb9ad7e3f
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:20 Changed 2 years ago by mkoeppe

  • Authors changed from Alex J. Best to Alex J. Best
  • Commit 3051fcc78d101b278f2e0fe65887e7afb9ad7e3f deleted
Note: See TracTickets for help on using tickets.