#29121 closed defect (fixed)

One-line fix for blocker ".pc files generated in src/ are not cleaned by `make misc-clean` / `make distclean`

Reported by: mkoeppe Owned by:
Priority: blocker Milestone: sage-9.1
Component: build: configure Keywords:
Cc: dimpase, embray, vbraun Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: c06fc37 (Commits, GitHub, GitLab) Commit: c06fc370233a6bab490fb2e26342613f20c2a3c5
Dependencies: Stopgaps:

Status badges

Description

This is a hot fix for the blocker regression introduced in #29003. It should go into the next beta.

It will be easier to review than the complete solution at:

  • #29082 - "Move .pc file from src/ to build/, clean generated *.pc files at 'make distclean'"

Change History (5)

comment:1 Changed 18 months ago by mkoeppe

  • Branch set to u/mkoeppe/one_line_fix_for_blocker___pc_files_generated_in_src__are_not_cleaned_by__make_misc_clean_____make_distclean_

comment:2 Changed 18 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to c06fc370233a6bab490fb2e26342613f20c2a3c5
  • Status changed from new to needs_review

New commits:

c06fc37Makefile [misc-clean]: Delete configure-generated files src/lib/pkgconfig/*

comment:3 Changed 18 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:4 Changed 18 months ago by mkoeppe

Thanks!

comment:5 Changed 18 months ago by vbraun

  • Branch changed from u/mkoeppe/one_line_fix_for_blocker___pc_files_generated_in_src__are_not_cleaned_by__make_misc_clean_____make_distclean_ to c06fc370233a6bab490fb2e26342613f20c2a3c5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.