#29120 closed defect (fixed)

Two-line fix for "./configure is too sensitive to stray files/subdirectories"

Reported by: mkoeppe Owned by:
Priority: blocker Milestone: sage-9.1
Component: build Keywords:
Cc: dimpase, embray, vbraun Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 171181f (Commits, GitHub, GitLab) Commit: 171181f7c860bb791d75eeb4c76c6102681ffa20
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

This branch can be merged by people who are working with tickets pre-9.1.beta2 who cannot easily merge current develop into that ticket.

It turns an error issued by configure when they are stray files in build/pkgs (such as the generated files introduced in #29038).

Before this ticket:

$ mkdir -p build/pkgs/xyzzy/foo
$ ./bootstrap && ./configure
...
configure: error: "/Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/build/pkgs/xyzzy/type" is missing.

After this ticket:

...
configure: WARNING: "/Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/build/pkgs/xyzzy/type" is missing.  Leftovers from another branch?
...

Change History (17)

comment:1 Changed 18 months ago by mkoeppe

  • Description modified (diff)

comment:2 Changed 18 months ago by mkoeppe

  • Branch set to u/mkoeppe/one-line-fix-configure-too-sensitive-to-stray-files-in-build-pkgs

comment:3 Changed 18 months ago by mkoeppe

  • Commit set to 1f193bfcd4d38917f1a4b24e6c7b3e5541344054

The branch is on top of sage 8.7.


New commits:

1f193bfIssue only a warning, not an error, if there are stray files in build/pkgs

comment:4 Changed 18 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Status changed from new to needs_review

comment:5 Changed 18 months ago by mkoeppe

  • Priority changed from major to blocker
  • Status changed from needs_review to needs_work

comment:6 Changed 18 months ago by mkoeppe

  • Status changed from needs_work to needs_review

comment:7 Changed 18 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:8 Changed 18 months ago by mkoeppe

Thanks!

comment:9 Changed 18 months ago by git

  • Commit changed from 1f193bfcd4d38917f1a4b24e6c7b3e5541344054 to 171181f7c860bb791d75eeb4c76c6102681ffa20
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

171181ffixup

comment:10 Changed 18 months ago by mkoeppe

  • Status changed from needs_review to needs_work
  • Summary changed from One-line fix for "./configure is too sensitive to stray files/subdirectories" to Two-line fix for "./configure is too sensitive to stray files/subdirectories"

Sometimes 2 lines are better than 1.

comment:11 Changed 18 months ago by mkoeppe

  • Status changed from needs_work to needs_review

comment:12 Changed 18 months ago by dimpase

Could we please avoid continue, by putting the stuff to run fully into then clause?

comment:13 Changed 18 months ago by mkoeppe

I think it's better if the diff is small.

comment:14 Changed 18 months ago by dimpase

  • Status changed from needs_review to positive_review

I don't like this Fortran coding style, but OK :-)

comment:15 Changed 18 months ago by mkoeppe

Thanks!

comment:16 Changed 18 months ago by embray

+1 thanks.

comment:17 Changed 18 months ago by vbraun

  • Branch changed from u/mkoeppe/one-line-fix-configure-too-sensitive-to-stray-files-in-build-pkgs to 171181f7c860bb791d75eeb4c76c6102681ffa20
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.