Opened 2 years ago
Closed 2 years ago
#29117 closed enhancement (fixed)
Implement a maximal chain for combinatorial polyhedron
Reported by: | gh-kliem | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.1 |
Component: | geometry | Keywords: | combinatorial polyhedron, maximal chain |
Cc: | jipilab, gh-LaisRast | Merged in: | |
Authors: | Jonathan Kliem | Reviewers: | Jean-Philippe Labbé, Laith Rastanawi |
Report Upstream: | N/A | Work issues: | |
Branch: | 2e9f25f (Commits, GitHub, GitLab) | Commit: | 2e9f25f044932e8e1ce5c9f9623893b6d2d2b23a |
Dependencies: | Stopgaps: |
Description
We implement a method that returns a maximal chain of the face lattice of a combinatorial polyhedron without empty face and universe.
With this we can easily obtain vertices spanning the affine hull of a polytope.
Change History (7)
comment:1 Changed 2 years ago by
- Branch set to public/29117
- Commit set to a8359e0ffa390eac98d9b14597b7f9ceb8fe1cbd
- Status changed from new to needs_review
comment:2 Changed 2 years ago by
- Reviewers set to Laith Rastanawi
Looks good to me. Some minor things:
- Say that the faces are listed in an increasing order.
- Change the word "universe" to something more familiar (e.g. the whole polyhedron, the maximal face..)
comment:3 Changed 2 years ago by
It would be nice if you could add this feature for polyhedron objects as well?
comment:4 Changed 2 years ago by
- Branch changed from public/29117 to public/29117-reb
- Commit changed from a8359e0ffa390eac98d9b14597b7f9ceb8fe1cbd to 2e9f25f044932e8e1ce5c9f9623893b6d2d2b23a
comment:5 Changed 2 years ago by
- Reviewers changed from Laith Rastanawi to Jean-Philippe Labbé, Laith Rastanawi
I will wait for the patchbot to finish, then I will put it on positive review.
comment:6 Changed 2 years ago by
- Status changed from needs_review to positive_review
comment:7 Changed 2 years ago by
- Branch changed from public/29117-reb to 2e9f25f044932e8e1ce5c9f9623893b6d2d2b23a
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
implement `a_maximal_chain` for combinatorial polyhedron