Opened 3 years ago

Closed 2 years ago

#29112 closed enhancement (fixed)

Implement incidence matrix for combinatorial polyhedron

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.1
Component: geometry Keywords: incidence matrix, combinatorial polyhedron
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Laith Rastanawi
Report Upstream: N/A Work issues:
Branch: 6ee9276 (Commits, GitHub, GitLab) Commit: 6ee927616c12fb3bd0db6442e10c9b36ca2b5fd2
Dependencies: Stopgaps:

Status badges


We implement the incidence matrix for CombinatorialPolyhedron. This is just exposure of the already present combinatorial data in a nice presentation for the user.

Change History (4)

comment:1 Changed 3 years ago by gh-kliem

  • Status changed from new to needs_review

comment:2 Changed 3 years ago by gh-kliem

  • Branch set to public/29122
  • Commit set to 6ee927616c12fb3bd0db6442e10c9b36ca2b5fd2

Forgot to set the branch.

New commits:

6ee9276implement incidence matrix for combinatorial polyhedron

comment:3 Changed 3 years ago by gh-LaisRast

  • Reviewers set to Laith Rastanawi
  • Status changed from needs_review to positive_review

It looks good to me. (pyflakes warnings are to be handled in #28880)

Last edited 3 years ago by gh-LaisRast (previous) (diff)

comment:4 Changed 2 years ago by vbraun

  • Branch changed from public/29122 to 6ee927616c12fb3bd0db6442e10c9b36ca2b5fd2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.