Opened 3 years ago

Closed 3 years ago

#29085 closed enhancement (fixed)

CombinatorialPolyhedron: Expose `is_bounded`

Reported by: gh-kliem Owned by:
Priority: minor Milestone: sage-9.1
Component: geometry Keywords: combinatorial polyhedron, compactness
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Laith Rastanawi
Report Upstream: N/A Work issues:
Branch: 072708f (Commits, GitHub, GitLab) Commit: 072708fd53aa170fd7f95388691810d50c62b6e8
Dependencies: Stopgaps:

Status badges


CombinatorialPolyhedron has a method is_bounded, which is cython-only.

We expose this method under the name is_compact as in Polyhedron_base. Before it was hard to access this information.

Change History (6)

comment:1 Changed 3 years ago by gh-kliem

  • Branch set to public/29085
  • Commit set to 19ccbe34b8d0c2bb84c170038a75a816225b772b
  • Status changed from new to needs_review

New commits:

19ccbe3expose is_bounded of CombinatorialPolyhedron

comment:2 Changed 3 years ago by gh-LaisRast

You misspelled the word polyhedron. Otherwise everything looks good.

comment:3 Changed 3 years ago by git

  • Commit changed from 19ccbe34b8d0c2bb84c170038a75a816225b772b to 072708fd53aa170fd7f95388691810d50c62b6e8

Branch pushed to git repo; I updated commit sha1. New commits:


comment:4 Changed 3 years ago by gh-kliem

Ok, fixed.

comment:5 Changed 3 years ago by gh-LaisRast

  • Reviewers set to Laith Rastanawi
  • Status changed from needs_review to positive_review

comment:6 Changed 3 years ago by vbraun

  • Branch changed from public/29085 to 072708fd53aa170fd7f95388691810d50c62b6e8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.