Opened 20 months ago

Last modified 18 months ago

#29082 closed defect

Move .pc file from src/ to build/, clean generated *.pc files at 'make distclean' — at Version 7

Reported by: dimpase Owned by:
Priority: blocker Milestone: sage-9.1
Component: build: configure Keywords:
Cc: embray, mkoeppe, jhpalmieri, vbraun, fbissey Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #29071 Stopgaps:

Status badges

Description (last modified by dimpase)

#29003 introduced 2-stage installation of generated *.pc files, via src/lib/pkgconfig- but did not provide a way to clean them up at all. And this is a problem (cf. e.g. #29071). The generated files are for sage-the-distribution, not sagelib, so they belong into build, not src.

Because configure (config.status) creates them, make distclean should clean them, if not make clean.

Change History (7)

comment:1 Changed 20 months ago by dimpase

  • Cc mkoeppe added
  • Status changed from new to needs_info

comment:2 follow-up: Changed 20 months ago by mkoeppe

My suggestion would be to rewrite this as a script package instead of putting things into src/. This stuff really does not belong into src/.

comment:3 Changed 20 months ago by mkoeppe

  • Dependencies set to #29071
  • Description modified (diff)
  • Summary changed from clean generated *.pc files to Move .pc file from src/ to build/, clean generated *.pc files at 'make distclean'

Added #29071 as a dependency as it touches the same files.

comment:4 Changed 20 months ago by mkoeppe

  • Status changed from needs_info to needs_work

comment:5 follow-up: Changed 20 months ago by mkoeppe

(deleted a comment that was intended for #29071.)

Last edited 20 months ago by mkoeppe (previous) (diff)

comment:6 in reply to: ↑ 5 Changed 20 months ago by mkoeppe

(deleted a comment that was intended for #29071.)

Last edited 20 months ago by mkoeppe (previous) (diff)

comment:7 in reply to: ↑ 2 Changed 20 months ago by dimpase

  • Description modified (diff)

Replying to mkoeppe:

My suggestion would be to rewrite this as a script package instead of putting things into src/. This stuff really does not belong into src/.

Perhaps we should just create var/ next to src/ and put these things there?

Note: See TracTickets for help on using tickets.